Temporarily disable usage of scalars_multirun endpoint #4233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
approved these changes
Oct 14, 2020
| } else { | ||
| return this._requestDataPost(items, onLoad, onFinish); | ||
| } | ||
| // TODO(psybuzz): Ideally, we would always make use of `_requestDataPost`, |
Contributor
There was a problem hiding this comment.
Could we get away with a smaller delta here and leave most of the code intact so it's easy to revert? E.g.
// TODO(b/170675710): Stop unconditionally forcing legacy endpoint when fixed.
const forceLegacyEnpoint = true;
if (inColab || forceLegacyEndpoint) {
return this._requestDataGet(items, onLoad, onFinish);
} else {
return this._requestDataPost(items, onLoad, onFinish);
}That makes it obvious that we'll still need to the inColab check after resolving the TODO, which is better IMO than stating this fact in a comment. And I'm not sure we need to link to the spanner PR given that the gating factor isn't anything to do with the PR per se but rather with Google-internal release details which aren't particularly visible or meaningful outside Google anyway.
Contributor
Author
There was a problem hiding this comment.
That's much more concise! Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /scalars_multirun endpoint triggers errors when TensorBoard is
hosted with a Google Cloud Spanner backend. This change reverts
TensorBoard back to using
_requestDataGetunconditionally.Once [1] is synced into Google, we plan to re-enable the
_requestDataPostpath for non-Colab environments.Manually checked that the scalars dashboard makes GET requests
to
/data/plugin/scalars/scalarswith and without the?tensorboardColab=trueflag.Googlers, see b/170675710.
[1] googleapis/python-spanner#144