Skip to content

Temporarily disable usage of scalars_multirun endpoint #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Temporarily disable usage of scalars_multirun endpoint #4233

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af3ed80
Temporarily disable usage of scalars_multirun endpoint
psybuzz Oct 14, 2020
d3c70d7
ac concise
psybuzz Oct 14, 2020
567052f
typo
psybuzz Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tensorboard/plugins/scalar/tf_scalar_dashboard/tf-scalar-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,15 @@ export class TfScalarCard extends PolymerElement {
onLoad,
onFinish
) => {
// Google-internal Colab doesn't support HTTP POST requests, so we fall
// back to HTTP GET (even though public Colab supports POST).
// See b/126387106.
const inColab = initialURLSearchParams.get('tensorboardColab') === 'true';
if (inColab) {
// Google-internal Colab doesn't support HTTP POST requests, so we fall
// back to HTTP GET (even though public Colab supports POST).

// TODO(b/170675710): Stop unconditionally forcing legacy endpoint when
// fixed.
const forceLegacyEndpoint = true;
if (inColab || forceLegacyEndpoint) {
return this._requestDataGet(items, onLoad, onFinish);
} else {
return this._requestDataPost(items, onLoad, onFinish);
Expand Down