Skip to content

Strtotime and touch parameters default values are not enforced. #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2019
Merged

Strtotime and touch parameters default values are not enforced. #85

merged 3 commits into from
Jan 30, 2019

Conversation

@moufmouf
Copy link
Member

@moufmouf moufmouf commented Jan 23, 2019

See #83

This PR starts with a failing test

@moufmouf moufmouf mentioned this pull request Jan 23, 2019
Closed
@coveralls
Copy link

coveralls commented Jan 30, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 153

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 34.34%
Files with Coverage Reduction New Missed Lines %
src/Parameter.php 13 44.44%
Totals Coverage Status
Change from base Build 150: -0.5%
Covered Lines: 182
Relevant Lines: 530
💛 - Coveralls

@moufmouf moufmouf merged commit 0ed4676 into thecodingmachine:master Jan 30, 2019
@moufmouf moufmouf deleted the strtotime_touch branch January 30, 2019 14:46
@moufmouf moufmouf mentioned this pull request Jan 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moufmouf @coveralls