Explicitly encode data passed to securesystemslib.keys #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
securesystemslib PR #162 removed implicit encoding of data to bytes in securesystemslib.keys.[create_signature|verify_signature] Update to encode data where required. Signed-off-by: Joshua Lock <[email protected]>
Merged
3 tasks
|
Will be merged with #934. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this change breaks compatibility with ssl v0.11.3 and thus should not be merged until a new release of ssl has been made and is available on PyPI.
PR secure-systems-lab/securesystemslib#162 removed implicit encoding of data to bytes in securesystemslib.keys.[create_signature|verify_signature]
Fixes issue #: #913
Description of the changes being introduced by the pull request: explicitly encode data we pass to
securesystemslib.keys.create_signatureandsecuresystemslib.keys.verify_signaturePlease verify and check that the pull request fulfills the following
requirements: