Update securesystemslib to 0.12.0 #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Puehringer <[email protected]>
securesystemslib PR theupdateframework#162 removed implicit encoding of data to bytes in securesystemslib.keys.[create_signature|verify_signature] Update to encode data where required. Signed-off-by: Joshua Lock <[email protected]>
The class has been removed from securesystemslib as its desirable features are no longer required and its behavioural inconsistencies with a standard Python file object are confusing. Therefore remove uses of the class from TUF. Signed-off-by: Joshua Lock <[email protected]> Signed-off-by: Lukas Puehringer <[email protected]>
This was referenced Oct 14, 2019
|
I'm merging this PR despite failing AppVeyor build and missing review, because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
Closes #28.
Supersedes #917 and #918.
Description of the changes being introduced by the pull request:
Updates pinned version of
securesystemslibdependency in*requirements.txtandsetup.pyto latest 0.12.0.The update requires a few adjustments due to breaking changes in securesystemslib 0.12.0, which were kindly provided by @joshuagl in #917 and #918:
securesystemslib.keys.create_signatureandsecuresystemslib.keys.verify_signaturesecuresystemslib.util.TempFilein favour oftempfile.TemporaryFilefrom the Python standard libraryThese changes are incorporated with this PR, fixing minor merge conflicts due to #885.
Please verify and check that the pull request fulfills the following
requirements: