Refactor publish_docker_image.yml workflow
#378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For development, the API base URL is taken from the `.env` file. ``` API_BASE_URL=http://localhost:3001/v1 ``` For production, you can use the pre-build docker image which uses the default value set at building time (`http://localhost:3001/v1`). If you want, you can overwrite it when you run the new app with the env var `NUXT_PUBLIC_API_BASE` but it only works if you are serving the app with node. It doesn't work for static web app. You new to rebuild the app with your value for the env var `API_BASE_URL` so that it's included in the packaged app.
josecelano
added
Code Cleanup / Refactoring
It will allow us to use the same strcuture as the workflow to publish the docker image in the Index and Tracker projects.
They were replace by a single workflow: `container.yaml`, folowwing the same structure as in the Tracker and Index.
|
ACK 3e1ef2f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NUXT_PUBLIC_API_BASEto docker compose configuration to overwrite API URL at runtime.debugtoContainerfile.publish_docker_image.ymlworkflow to follow the same structure as in the Index.