feat(ImportantFilesView): org managers can do tasks #1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only owners can see the edit button when the active tab is a file.
…d permissions - Integrated package data into ImportantFilesView for AI description and usage instructions. - Updated permission checks to determine if the user can manage the package based on organization permissions or ownership. - Adjusted rendering logic to conditionally display AI review and edit buttons based on the new permission checks. - Modified useOrganization hook to accept GitHub handle as an alternative identifier for organizations.
….tsx Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
seveibar
requested changes
Sep 27, 2025
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
seveibar
approved these changes
Oct 3, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| }: { orgId?: string; orgName?: string; github_handle?: string }) => { | ||
| const axios = useAxios() | ||
|
|
||
| const orgQuery = useQuery<PublicOrgSchema, Error & { status: number }>( |
There was a problem hiding this comment.
The query key should include the github_handle parameter to maintain cache consistency. Currently, the key only includes orgId or orgName, but not the newly added parameter. Consider updating it to:
["orgs", "get", orgId || orgName || github_handle]This ensures that queries with different GitHub handles will be properly cached as separate entries, preventing potential stale data issues when switching between different parameter combinations.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.