-
Notifications
You must be signed in to change notification settings - Fork 87
feat(ImportantFilesView): org managers can do tasks #1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
87c727d
Update file view to conditionally render edit button for owners
ArnavK-09 a2a934b
fix pos of actions for folders in editor
ArnavK-09 e59d461
Discard changes to src/components/FileSidebar.tsx
ArnavK-09 1b2939a
Discard changes to src/components/ui/tree-view.tsx
ArnavK-09 f0c64f5
Refactor ImportantFilesView to utilize package data for AI content an…
ArnavK-09 37785dd
f
ArnavK-09 997a220
Update src/components/ViewPackagePage/components/important-files-view…
ArnavK-09 38a75da
format
ArnavK-09 ed9b19f
f
ArnavK-09 8745628
Update important-files-view.tsx
ArnavK-09 884eed8
Update important-files-view.tsx
ArnavK-09 57cd1f5
Update important-files-view.tsx
ArnavK-09 45ae952
Add can_manage_package to org schema
ArnavK-09 c75db9b
Update use-organization.ts
ArnavK-09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The query key should include the
github_handleparameter to maintain cache consistency. Currently, the key only includesorgIdororgName, but not the newly added parameter. Consider updating it to:This ensures that queries with different GitHub handles will be properly cached as separate entries, preventing potential stale data issues when switching between different parameter combinations.
Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.
This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.