Fix onError prop-type warning in Link

[oliviertassinari]

The warning

Warning: Failed prop type: Link: unknown props found: onError

can happen in this case:

import * as React from 'react';
import NextLink, { LinkProps as NextLinkProps } from 'next/link';

type NextComposedProps = React.AnchorHTMLAttributes<HTMLAnchorElement> & NextLinkProps;

const NextComposed = React.forwardRef<HTMLAnchorElement, NextComposedProps>((props, ref) => {
  const { as, href, replace, scroll, passHref, shallow, prefetch, onError, ...other } = props;

  return (
    <NextLink
      href={href}
      prefetch={prefetch}
      as={as}
      replace={replace}
      scroll={scroll}
      shallow={shallow}
      passHref={passHref}
      onError={onError}
    >
      <a ref={ref} {...other} />
    </NextLink>
  );
});

Taken from Material-UI Next.js integration example

[github-actions]

Stats from current PR

Click to expand stats

	zeit/next.js canary	oliviertassinari/next.js patch-1	Change
Build Duration	13.3s	13.4s	⚠️ +67ms
node_modules Size	45.5 MB	45.5 MB	⚠️ +109 B
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	✓
Client _app Size	2.39 kB	2.39 kB	✓
Client _app gzip Size	1.08 kB	1.08 kB	⚠️ +1 B
Client _error Size	8.45 kB	8.45 kB	✓
Client _error gzip Size	3.24 kB	3.24 kB	✓
Client pages/index Size	296 B	296 B	✓
Client pages/index gzip Size	224 B	222 B	-2 B
Client pages/link Size	4.14 kB	4.14 kB	✓
Client pages/link gzip Size	1.82 kB	1.82 kB	✓
Client pages/routerDirect Size	423 B	423 B	✓
Client pages/routerDirect gzip Size	306 B	306 B	✓
Client pages/withRouter Size	435 B	435 B	✓
Client pages/withRouter gzip Size	300 B	301 B	⚠️ +1 B
Client main Size	19.8 kB	19.8 kB	✓
Client main gzip Size	6.78 kB	6.78 kB	⚠️ +1 B
Client commons Size	184 kB	184 kB	✓
Client commons gzip Size	59.7 kB	59.7 kB	✓
Client webpack Size	1.49 kB	1.49 kB	✓
Client webpack gzip Size	770 B	770 B	✓
Base Rendered Size	1.36 kB	1.36 kB	✓
Build Dir Size	737 kB	737 kB	⚠️ +44 B

Click to expand serverless stats

	zeit/next.js canary	oliviertassinari/next.js patch-1	Change
Build Duration	14.6s	14.5s	-109ms
node_modules Size	45.5 MB	45.5 MB	⚠️ +109 B
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	✓
Client _app Size	2.39 kB	2.39 kB	✓
Client _app gzip Size	1.08 kB	1.08 kB	✓
Client _error Size	8.45 kB	8.45 kB	✓
Client _error gzip Size	3.24 kB	3.24 kB	✓
Client pages/index Size	296 B	296 B	✓
Client pages/index gzip Size	222 B	222 B	✓
Client pages/link Size	4.14 kB	4.14 kB	✓
Client pages/link gzip Size	1.82 kB	1.82 kB	✓
Client pages/routerDirect Size	423 B	423 B	✓
Client pages/routerDirect gzip Size	306 B	306 B	✓
Client pages/withRouter Size	435 B	435 B	✓
Client pages/withRouter gzip Size	301 B	301 B	✓
Client main Size	19.8 kB	19.8 kB	✓
Client main gzip Size	6.78 kB	6.78 kB	✓
Client commons Size	184 kB	184 kB	✓
Client commons gzip Size	59.7 kB	59.7 kB	✓
Client webpack Size	1.49 kB	1.49 kB	✓
Client webpack gzip Size	770 B	770 B	✓
Serverless pages/link Size	338 kB	338 kB	✓
Serverless pages/link gzip Size	86.9 kB	86.9 kB	✓
Serverless pages/index Size	Error getting size	Error getting size	✓
Serverless pages/index gzip Size	Error getting size	Error getting size	✓
Serverless pages/_error Size	329 kB	329 kB	✓
Serverless pages/_error gzip Size	84.2 kB	84.2 kB	✓
Serverless pages/routerDirect Size	330 kB	330 kB	✓
Serverless pages/routerDirect gzip Size	84.4 kB	84.4 kB	-1 B
Serverless pages/withRouter Size	330 kB	330 kB	✓
Serverless pages/withRouter gzip Size	84.4 kB	84.4 kB	✓
Build Dir Size	1.94 MB	1.94 MB	⚠️ +44 B

[timneutkens]

I wonder if this is really needed, it seems to never trigger / would cause other issues 🤔 Might make more sense to remove the property (as it would error out anyway in dev currently, so it must have been for multiple majors). Also it was never documented.

[oliviertassinari]

My initial motivation was to sync the TypeScript defintions with the prop-types. I don't have enough specific knowledge to respond on what direction should be taken.

[timneutkens]

Great! My main question was if you needed it for anything specific. Seems like you don't 👍💯

[oliviertassinari]

No, I don't need anything specific with this prop, I have never used it.

So I will remove the onError prop spread from the Material-UI + Next.js integration example. Do you want me to update the pull request to remove the prop?

[lfades]

@oliviertassinari You can update this PR or close it and create a new one 👍

[github-actions]

Stats from current PR

Click to expand stats

	zeit/next.js canary	oliviertassinari/next.js patch-1	Change
Build Duration	13.4s	13s	-416ms
node_modules Size	45.5 MB	45.5 MB	-221 B
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	✓
Client _app Size	2.39 kB	2.39 kB	✓
Client _app gzip Size	1.08 kB	1.08 kB	✓
Client _error Size	8.45 kB	8.45 kB	✓
Client _error gzip Size	3.24 kB	3.24 kB	✓
Client pages/index Size	343 B	343 B	✓
Client pages/index gzip Size	246 B	246 B	✓
Client pages/link Size	4.14 kB	4.08 kB	-56 B
Client pages/link gzip Size	1.82 kB	1.8 kB	-20 B
Client pages/routerDirect Size	423 B	423 B	✓
Client pages/routerDirect gzip Size	306 B	306 B	✓
Client pages/withRouter Size	435 B	435 B	✓
Client pages/withRouter gzip Size	301 B	301 B	✓
Client main Size	19.8 kB	19.8 kB	✓
Client main gzip Size	6.78 kB	6.78 kB	✓
Client commons Size	184 kB	184 kB	✓
Client commons gzip Size	59.7 kB	59.7 kB	✓
Client webpack Size	1.49 kB	1.49 kB	✓
Client webpack gzip Size	770 B	770 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	738 kB	738 kB	-304 B

Click to expand serverless stats

	zeit/next.js canary	oliviertassinari/next.js patch-1	Change
Build Duration	14.9s	14.6s	-267ms
node_modules Size	45.5 MB	45.5 MB	-221 B
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	✓
Client _app Size	2.39 kB	2.39 kB	✓
Client _app gzip Size	1.08 kB	1.08 kB	✓
Client _error Size	8.45 kB	8.45 kB	✓
Client _error gzip Size	3.24 kB	3.24 kB	✓
Client pages/index Size	343 B	343 B	✓
Client pages/index gzip Size	246 B	246 B	✓
Client pages/link Size	4.14 kB	4.08 kB	-56 B
Client pages/link gzip Size	1.82 kB	1.8 kB	-20 B
Client pages/routerDirect Size	423 B	423 B	✓
Client pages/routerDirect gzip Size	306 B	306 B	✓
Client pages/withRouter Size	435 B	435 B	✓
Client pages/withRouter gzip Size	301 B	301 B	✓
Client main Size	19.8 kB	19.8 kB	✓
Client main gzip Size	6.78 kB	6.78 kB	✓
Client commons Size	184 kB	184 kB	✓
Client commons gzip Size	59.7 kB	59.7 kB	✓
Client webpack Size	1.49 kB	1.49 kB	✓
Client webpack gzip Size	770 B	770 B	✓
Serverless pages/link Size	338 kB	338 kB	-94 B
Serverless pages/link gzip Size	86.9 kB	86.8 kB	-26 B
Serverless pages/index Size	329 kB	329 kB	✓
Serverless pages/index gzip Size	84.4 kB	84.4 kB	✓
Serverless pages/_error Size	329 kB	329 kB	✓
Serverless pages/_error gzip Size	84.2 kB	84.2 kB	-1 B
Serverless pages/routerDirect Size	330 kB	330 kB	✓
Serverless pages/routerDirect gzip Size	84.4 kB	84.4 kB	-2 B
Serverless pages/withRouter Size	330 kB	330 kB	✓
Serverless pages/withRouter gzip Size	84.4 kB	84.4 kB	-1 B
Build Dir Size	2.26 MB	2.26 MB	-304 B

[github-actions]

Stats from current PR

Click to expand stats

	zeit/next.js canary	oliviertassinari/next.js patch-1	Change
Build Duration	13.8s	13.6s	-249ms
node_modules Size	45.5 MB	45.5 MB	-180 B
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.9 kB	67.9 kB	✓
Client _app Size	2.39 kB	2.39 kB	✓
Client _app gzip Size	1.08 kB	1.08 kB	✓
Client _error Size	8.22 kB	8.22 kB	✓
Client _error gzip Size	3.16 kB	3.16 kB	✓
Client pages/index Size	343 B	343 B	✓
Client pages/index gzip Size	246 B	246 B	✓
Client pages/link Size	4.14 kB	4.08 kB	-56 B
Client pages/link gzip Size	1.82 kB	1.8 kB	-20 B
Client pages/routerDirect Size	423 B	423 B	✓
Client pages/routerDirect gzip Size	306 B	306 B	✓
Client pages/withRouter Size	435 B	435 B	✓
Client pages/withRouter gzip Size	301 B	301 B	✓
Client main Size	20 kB	20 kB	✓
Client main gzip Size	6.86 kB	6.86 kB	✓
Client commons Size	184 kB	184 kB	✓
Client commons gzip Size	59.7 kB	59.7 kB	✓
Client webpack Size	1.49 kB	1.49 kB	✓
Client webpack gzip Size	770 B	770 B	✓
Base Rendered Size	1.35 kB	1.35 kB	✓
Build Dir Size	704 kB	704 kB	-374 B

Click to expand serverless stats

	zeit/next.js canary	oliviertassinari/next.js patch-1	Change
Build Duration	15.1s	14.9s	-276ms
node_modules Size	45.5 MB	45.5 MB	-180 B
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.9 kB	67.9 kB	-2 B
Client _app Size	2.39 kB	2.39 kB	✓
Client _app gzip Size	1.08 kB	1.08 kB	-1 B
Client _error Size	8.22 kB	8.22 kB	✓
Client _error gzip Size	3.16 kB	3.16 kB	✓
Client pages/index Size	343 B	343 B	✓
Client pages/index gzip Size	246 B	246 B	✓
Client pages/link Size	4.14 kB	4.08 kB	-56 B
Client pages/link gzip Size	1.82 kB	1.8 kB	-20 B
Client pages/routerDirect Size	423 B	423 B	✓
Client pages/routerDirect gzip Size	306 B	306 B	✓
Client pages/withRouter Size	435 B	435 B	✓
Client pages/withRouter gzip Size	301 B	300 B	-1 B
Client main Size	20 kB	20 kB	✓
Client main gzip Size	6.86 kB	6.85 kB	-1 B
Client commons Size	184 kB	184 kB	✓
Client commons gzip Size	59.7 kB	59.7 kB	✓
Client webpack Size	1.49 kB	1.49 kB	✓
Client webpack gzip Size	770 B	770 B	✓
Serverless pages/link Size	252 kB	252 kB	-81 B
Serverless pages/link gzip Size	67.9 kB	67.9 kB	-18 B
Serverless pages/index Size	245 kB	245 kB	✓
Serverless pages/index gzip Size	65.7 kB	65.7 kB	⚠️ +2 B
Serverless pages/_error Size	244 kB	244 kB	✓
Serverless pages/_error gzip Size	65.5 kB	65.5 kB	⚠️ +1 B
Serverless pages/routerDirect Size	245 kB	245 kB	✓
Serverless pages/routerDirect gzip Size	65.7 kB	65.7 kB	✓
Serverless pages/withRouter Size	245 kB	245 kB	✓
Serverless pages/withRouter gzip Size	65.8 kB	65.8 kB	✓
Build Dir Size	1.89 MB	1.89 MB	-374 B