Skip to content

Fix onError prop-type warning in Link #8021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2019
Merged

Fix onError prop-type warning in Link #8021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
850e9e7
Fix onError prop-type warning in Link
oliviertassinari Jul 17, 2019
5932f08
remove onError
oliviertassinari Jul 19, 2019
74323af
Merge branch 'canary' into patch-1
Timer Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/next/client/link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ export type LinkProps = {
scroll?: boolean
shallow?: boolean
passHref?: boolean
onError?: (error: Error) => void
prefetch?: boolean
}

Expand Down Expand Up @@ -180,9 +179,6 @@ class Link extends Component<LinkProps> {
document.body.focus()
}
})
.catch((err: any) => {
if (this.props.onError) this.props.onError(err)
})
}

prefetch() {
Expand Down
1 change: 0 additions & 1 deletion test/integration/typescript/components/link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ export default () => {
const props: LinkProps = {
href: '/page',
as: '/as-page',
onError() {},
}

return (
Expand Down