Skip to content

XGRAMMAR now support aarch64 #13894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

XGRAMMAR now support aarch64 #13894

wants to merge 7 commits into from

Conversation

@johnnynunez
Copy link
Contributor

@johnnynunez johnnynunez commented Feb 26, 2025 •
edited by github-actions bot
Loading

This pull request includes updates to the requirements-common.txt file and modifications to the fallback_or_error function in the vllm/model_executor/guided_decoding/__init__.py file. The changes aim to update dependencies and streamline the guided decoding process.

Dependency updates:

Guided decoding improvements:

  • vllm/model_executor/guided_decoding/__init__.py: Removed the fallback logic for non-x86 CPUs and the check for CpuArchEnum.X86 in the fallback_or_error function, simplifying the code and removing unnecessary platform-specific handling.

@johnnynunez johnnynunez requested a review from mgoin as a code owner February 26, 2025 12:03
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@shen-shanshan shen-shanshan mentioned this pull request Feb 28, 2025
Closed
@shen-shanshan
Copy link
Contributor

@johnnynunez

Could you please update the xgrammar version in requirement to v0.1.14 ? Then I will colse my PR.

Find more details at here.

@johnnynunez
Copy link
Contributor Author

@johnnynunez

Could you please update the xgrammar version in requirement to v0.1.14 ? Then I will colse my PR.

Find more details at here.

Done

@mergify mergify bot added the ci/build label Mar 3, 2025
@mergify mergify bot added documentation Improvements or additions to documentation frontend speculative-decoding v1 labels Mar 3, 2025
@johnnynunez johnnynunez closed this Mar 3, 2025
@johnnynunez johnnynunez reopened this Mar 3, 2025
@shen-shanshan shen-shanshan mentioned this pull request Mar 4, 2025
Closed
20 tasks
mgoin
mgoin reviewed Mar 5, 2025
View reviewed changes
@johnnynunez johnnynunez force-pushed the patch-2 branch 2 times, most recently from ceab9e2 to ad9438f Compare March 6, 2025 11:55
@johnnynunez johnnynunez closed this Mar 9, 2025
@johnnynunez johnnynunez reopened this Mar 9, 2025
@johnnynunez johnnynunez requested a review from russellb as a code owner March 9, 2025 12:54
@johnnynunez
Copy link
Contributor Author

@mgoin when will it be merged?

@robertgshaw2-redhat
Copy link
Collaborator

your pre-commit is failing

@mergify mergify bot mentioned this pull request Mar 10, 2025
Closed
johnnynunez and others added 7 commits March 10, 2025 13:20
@johnnynunez
Update common.txt
e3e3cb6 
Signed-off-by: Johnny <[email protected]>
Signed-off-by: johnnynunez <[email protected]>
@johnnynunez
Update __init__.py
38703c3 
Signed-off-by: Johnny <[email protected]>
Signed-off-by: johnnynunez <[email protected]>
@johnnynunez
Update __init__.py
57499f5 
Signed-off-by: Johnny <[email protected]>
Signed-off-by: johnnynunez <[email protected]>
@martinhoyer @johnnynunez
[Bugfix] Wrong requirements path - rocm (#14527)
a4e8a67 
Signed-off-by: Martin Hoyer <[email protected]>
Signed-off-by: johnnynunez <[email protected]>
@JenZhao @ywang96 @johnnynunez
[Feature] Consolidate performance benchmark datasets (#14036)
50834e7 
Signed-off-by: Jennifer Zhao <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Co-authored-by: Jennifer Zhao <[email protected]>
Co-authored-by: Roger Wang <[email protected]>
Signed-off-by: johnnynunez <[email protected]>
@chaunceyjiang @johnnynunez
[Misc] Add log information for handle_process_request. (#14130)
f4cda0e 
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: johnnynunez <[email protected]>
@johnnynunez
fix
cf6c3c3 
Signed-off-by: johnnynunez <[email protected]>
@johnnynunez
Copy link
Contributor Author

your pre-commit is failing

done!

russellb
russellb requested changes Mar 10, 2025
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR appears to have a lot of extra unintended changes, perhaps from a bad merge / rebase.

@russellb russellb mentioned this pull request Mar 10, 2025
Closed
russellb added a commit to russellb/vllm that referenced this pull request Mar 10, 2025
@russellb
[Build/CI] Upgrade xgrammar to >=0.1.15
b913bb6 
This update includes support for aarch64 among other fixes and improvements.

Closes vllm-project#11886
Closes vllm-project#13986

Implements part of vllm-project#13894

Signed-off-by: Russell Bryant <[email protected]>
russellb added a commit to russellb/vllm that referenced this pull request Mar 11, 2025
@russellb
[Build/CI] Upgrade xgrammar to >=0.1.15
4b5bd40 
This update includes support for aarch64 among other fixes and improvements.

Closes vllm-project#11886
Closes vllm-project#13986

Implements part of vllm-project#13894

Signed-off-by: Russell Bryant <[email protected]>
@aarnphm
Copy link
Collaborator

aarnphm commented Mar 16, 2025

This will be addressed by #14868

@aarnphm aarnphm closed this Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin left review comments

@russellb russellb russellb requested changes

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

@comaniac comaniac Awaiting requested review from comaniac

@youkaichao youkaichao Awaiting requested review from youkaichao

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@njhill njhill Awaiting requested review from njhill

@LiuXiaoxuanPKU LiuXiaoxuanPKU Awaiting requested review from LiuXiaoxuanPKU

@KuntaiDu KuntaiDu Awaiting requested review from KuntaiDu

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337

@ywang96 ywang96 Awaiting requested review from ywang96

@simon-mo simon-mo Awaiting requested review from simon-mo

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123

Assignees

No one assigned

Labels

ci/build documentation Improvements or additions to documentation frontend speculative-decoding structured-output v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@johnnynunez @shen-shanshan @robertgshaw2-redhat @aarnphm @russellb @mgoin @martinhoyer @JenZhao @chaunceyjiang