Skip to content

[Build/CI] Upgrade xgrammar to 0.1.15 #14563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Build/CI] Upgrade xgrammar to 0.1.15 #14563

wants to merge 2 commits into from

Conversation

@russellb
Copy link
Member

This update includes support for aarch64 among other fixes and improvements.

Closes #11886
Closes #13986

Implements part of #13894

Signed-off-by: Russell Bryant [email protected]

@russellb russellb requested a review from mgoin March 10, 2025 13:30
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 10, 2025
@russellb
[Build/CI] Upgrade xgrammar to >=0.1.15
b913bb6 
This update includes support for aarch64 among other fixes and improvements.

Closes vllm-project#11886
Closes vllm-project#13986

Implements part of vllm-project#13894

Signed-off-by: Russell Bryant <[email protected]>
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 10, 2025
@WoosukKwon
Copy link
Collaborator

QQ: Does this upgrade increase the coverage of xgrammar? E.g., supporting regex, etc.

mgoin
mgoin reviewed Mar 11, 2025
View reviewed changes
@russellb russellb mentioned this pull request Mar 11, 2025
Merged
@WoosukKwon WoosukKwon changed the title [Build/CI] Upgrade xgrammar to >=0.1.15 [Build/CI] Upgrade xgrammar to 0.1.15 Mar 11, 2025
russellb added a commit to russellb/vllm that referenced this pull request Mar 11, 2025
@russellb
[V1] Add regex structured output support with xgrammar
d55cfbd 
This is built on top of vllm-project#14563, as the upgraded xgrammar is required for regex
support to work.

Signed-off-by: Russell Bryant <[email protected]>
@russellb
Copy link
Member Author

QQ: Does this upgrade increase the coverage of xgrammar? E.g., supporting regex, etc.

Yes, it lets us turn on regex support. #14590

It also fixes a bug that caused us to pin to 0.1.11 previously: #13338

@russellb
Copy link
Member Author

This got merged as part of #14590

@russellb russellb closed this Mar 11, 2025
@Ryp Ryp mentioned this pull request Mar 12, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin left review comments

@WoosukKwon WoosukKwon WoosukKwon approved these changes

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

3 participants

@russellb @WoosukKwon @mgoin