-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[Build/CI] Add tracing deps to vllm container image #15224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Perhaps a comment saying why these deps are here, similar to other deps? Something like # Required for vllm.tracing
Thanks! rebased and added those comments |
Can you merge from main to fix docker build? |
A report requested that these dependencies be included in the image for tracing. That seems reasonable - they are needed by `vllm.tracing`. Stop manually installing them in the relevant test pipeline and just include them in the image. Signed-off-by: Russell Bryant <[email protected]>
done - rebased on main |
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
This actually broke my python dependencies since we're also using grpc + protobuf, but with protobuf version > 5, which has a dependency conflict with opentelemetry-exporter-otlp>=1.26.0,<1.27.0. In my opinion, this should be an optional dependency (pip extra maybe?). If this is not an option, another possibility would be to upgrade the opentelemetry dependencies to at least 1.28.0 since protobuf v5 is used from there on (open-telemetry/opentelemetry-python@d1904b9). Looking forward to your response. |
There will be a PR soon that removes the upper limit on the |
I have the same problem. Looking forward to the response. |
Yes this fixes the issue for me, temporarily fixed it in https://github.com/robertaistleitner/vllm/tree/stable/v0.8.5.post1 for my use-case using from source install with prebuilt wheel ( |
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Mu Huai <[email protected]>
…ject#15224)" This reverts commit fee5b8d. Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
A report requested that these dependencies be included in the image
for tracing. That seems reasonable - they are needed by
vllm.tracing
. Stop manually installing them in the relevant testpipeline and just include them in the image.
Signed-off-by: Russell Bryant [email protected]