Skip to content

Conversation

russellb
Copy link
Member

A report requested that these dependencies be included in the image
for tracing. That seems reasonable - they are needed by
vllm.tracing. Stop manually installing them in the relevant test
pipeline and just include them in the image.

Signed-off-by: Russell Bryant [email protected]

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

mergify bot commented Mar 20, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @russellb.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Perhaps a comment saying why these deps are here, similar to other deps? Something like # Required for vllm.tracing

@russellb
Copy link
Member Author

russellb commented Apr 8, 2025

LGTM!

Perhaps a comment saying why these deps are here, similar to other deps? Something like # Required for vllm.tracing

Thanks! rebased and added those comments

@hmellor hmellor enabled auto-merge (squash) April 8, 2025 21:44
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 8, 2025
@DarkLight1337
Copy link
Member

Can you merge from main to fix docker build?

A report requested that these dependencies be included in the image
for tracing. That seems reasonable - they are needed by
`vllm.tracing`. Stop manually installing them in the relevant test
pipeline and just include them in the image.

Signed-off-by: Russell Bryant <[email protected]>
@russellb
Copy link
Member Author

russellb commented Apr 9, 2025

Can you merge from main to fix docker build?

done - rebased on main

@hmellor hmellor merged commit fee5b8d into vllm-project:main Apr 9, 2025
68 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@robertaistleitner
Copy link

This actually broke my python dependencies since we're also using grpc + protobuf, but with protobuf version > 5, which has a dependency conflict with opentelemetry-exporter-otlp>=1.26.0,<1.27.0. In my opinion, this should be an optional dependency (pip extra maybe?).

If this is not an option, another possibility would be to upgrade the opentelemetry dependencies to at least 1.28.0 since protobuf v5 is used from there on (open-telemetry/opentelemetry-python@d1904b9).

Looking forward to your response.

@hmellor
Copy link
Member

hmellor commented May 6, 2025

There will be a PR soon that removes the upper limit on the opentelemetry-exporter-otlp version, will that solve the problem for you?

@fanqiNO1
Copy link

fanqiNO1 commented May 7, 2025

I have the same problem. Looking forward to the response.

@robertaistleitner
Copy link

Yes this fixes the issue for me, temporarily fixed it in https://github.com/robertaistleitner/vllm/tree/stable/v0.8.5.post1 for my use-case using from source install with prebuilt wheel (git clone and pip install -e .) and setting env VLLM_USE_PRECOMPILED=1 and VLLM_PRECOMPILED_WHEEL_LOCATION=https://files.pythonhosted.org/packages/47/07/e8822ca825f88aec61a7af6210b85cd0e0a4d6f757081d3282f32b1b0912/vllm-0.8.5.post1-cp38-abi3-manylinux1_x86_64.whl.

@russellb
Copy link
Member Author

russellb commented May 7, 2025

#17771

RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
kouroshHakha added a commit to kouroshHakha/vllm that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants