Skip to content

Conversation

Xarbirus
Copy link
Contributor

@Xarbirus Xarbirus commented May 7, 2025

These changes relax the OpenTelemetry version requirements, allowing newer packages to be used and reducing version conflicts.

FIX #17174

@github-actions
Copy link

github-actions bot commented May 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 7, 2025
@russellb russellb added the ready ONLY add when PR is ready to merge/full CI is needed label May 7, 2025
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see what the tests think!

@hmellor hmellor enabled auto-merge (squash) May 7, 2025 11:23
@Xarbirus
Copy link
Contributor Author

Xarbirus commented May 7, 2025

@hmellor @russellb the failed test looks related to this commit. The test uses python3.12, but in this case the field deprecated should be removed from kwargs.

@hmellor
Copy link
Member

hmellor commented May 7, 2025

deprecated should be there, but the usage of add_cli_args in the example script was incorrect, I have fixed it in #17781

@Xarbirus
Copy link
Contributor Author

Xarbirus commented May 7, 2025

great, will wait for it.

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@vllm-bot vllm-bot merged commit c747d84 into vllm-project:main May 8, 2025
78 of 80 checks passed
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Mikhail Podvitskii <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Installation]: Pinned version of OpenTelemetry in requirements

4 participants