Use repeat_interleave in Mamba2 seq_idx computation to reduce cpu-gpu syncs #16743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small patch to Mamba2 seq_idx metadata computation for prefill path. The original implementation uses a sequential for loop on CPU and the number of cpu-gpu synchronizations can increase with the batch size. With the patch, it avoids using the sequential for loop on host, and makes the code easier to read too. Verified no performance regression and observed a small 1.7% throughput increase with benchmark_serving using ShareGPTV3.
This PR
Main
lm_eval confirmed no change on quality