Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Jul 22, 2025

FIX #21083 (comment)

Refer to the AMD build for testing

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin added ready ONLY add when PR is ready to merge/full CI is needed ci-failure Issue about an unexpected test failure in CI labels Jul 22, 2025
@mergify mergify bot added the ci/build label Jul 22, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly restricts the compilation of per_token_group_quant.cu to CUDA builds only. The changes in CMakeLists.txt are consistent with the project's structure for handling platform-specific code. This is a necessary fix as the source file contains CUDA-specific intrinsics and is not compatible with other backends like ROCm. The change is correct and well-contained.

Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mgoin
Copy link
Member Author

mgoin commented Jul 22, 2025

Closing in favor of #21393

@mgoin mgoin closed this Jul 22, 2025
@yewentao256 yewentao256 deleted the fix-fp8-per_token_group_quant-cuda-build branch July 22, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ci-failure Issue about an unexpected test failure in CI ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants