Skip to content

Implement Ref copy constructor #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Implement Ref copy constructor #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 39 additions & 20 deletions include/godot_cpp/classes/ref.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,30 +125,33 @@ class Ref {
unref();
return;
}

Ref r;
r.reference = Object::cast_to<T>(refb);
ref(r);
r.reference = nullptr;
}

void operator=(const Variant &p_variant) {
// FIXME
// Needs testing, Variant has a cast to Object * here.

// Object *object = p_variant.get_validated_object();
Object *object = p_variant;

// if (object == reference) {
// return;
// }
if (object == reference) {
return;
}

// unref();
unref();

// if (!object) {
// return;
// }
if (!object) {
return;
}

// T *r = Object::cast_to<T>(object);
// if (r && r->reference()) {
// reference = r;
// }
T *r = Object::cast_to<T>(object);
if (r && r->reference()) {
reference = r;
}
}

template <class T_Other>
Expand All @@ -168,24 +171,40 @@ class Ref {
ref(p_from);
}

template <class T_Other>
Ref(const Ref<T_Other> &p_from) {
RefCounted *refb = const_cast<RefCounted *>(static_cast<const RefCounted *>(p_from.ptr()));
if (!refb) {
unref();
return;
}

Ref r;
r.reference = Object::cast_to<T>(refb);
ref(r);
r.reference = nullptr;
}

Ref(T *p_reference) {
if (p_reference) {
ref_pointer(p_reference);
}
}

Ref(const Variant &p_variant) {
// FIXME
// Needs testing, Variant has a cast to Object * here.

// Object *object = p_variant.get_validated_object();
Object *object = p_variant;

// if (!object) {
// return;
// }
if (!object) {
return;
}

// T *r = Object::cast_to<T>(object);
// if (r && r->reference()) {
// reference = r;
// }
T *r = Object::cast_to<T>(object);
if (r && r->reference()) {
reference = r;
}
}

inline bool is_valid() const { return reference != nullptr; }
Expand Down