Fix panic on incomplete closing frontmatter fence #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

wooorm merged 1 commit into wooorm:main from nokome:main

Aug 9, 2024

Contributor

nokome commented Aug 9, 2024

This fixes an out-of-range index panic when frontmatter only has two closing dashes e.g.

---
title: Some frontmatter
--

Some other content


          Fix panic on incomplete closing frontmatter fence

16ae3ac

Owner

wooorm commented Aug 9, 2024

Oh, wild that this was happening! Thanks for fixing it!

wooorm merged commit 2c83b0d into wooorm:main

Owner

wooorm commented Aug 9, 2024

released, thank you!!

Owner

wooorm commented Aug 9, 2024

p.s. seems the https::/stencila.io on your GH profile is wrong? should probably be ://?

renovate bot referenced this pull request in oxc-project/oxc


          chore(deps): update rust crates (#4828)

54592fb

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [markdown](https://togithub.com/wooorm/markdown-rs) | dev-dependencies
| patch | `1.0.0-alpha.18` -> `1.0.0-alpha.19` |
| [serde](https://serde.rs)
([source](https://togithub.com/serde-rs/serde)) | workspace.dependencies
| patch | `1.0.204` -> `1.0.206` |
| [tempfile](https://stebalien.com/projects/tempfile-rs/)
([source](https://togithub.com/Stebalien/tempfile)) |
workspace.dependencies | minor | `3.11.0` -> `3.12.0` |

---

### Release Notes

<details>
<summary>wooorm/markdown-rs (markdown)</summary>

###
[`v1.0.0-alpha.19`](https://togithub.com/wooorm/markdown-rs/releases/tag/1.0.0-alpha.19)

[Compare
Source](https://togithub.com/wooorm/markdown-rs/compare/1.0.0-alpha.18...1.0.0-alpha.19)

- [`2c83b0d`](https://togithub.com/wooorm/markdown-rs/commit/2c83b0d)
Fix panic on incomplete closing frontmatter fence
by [@&#8203;nokome](https://togithub.com/nokome) in
[https://github.com/wooorm/markdown-rs/pull/121](https://togithub.com/wooorm/markdown-rs/pull/121)
- [`d0788c9`](https://togithub.com/wooorm/markdown-rs/commit/d0788c9)
Update dev-dependencies
by [@&#8203;wooorm](https://togithub.com/wooorm) in
[https://github.com/wooorm/markdown-rs/pull/120](https://togithub.com/wooorm/markdown-rs/pull/120)

**Full Changelog**:
wooorm/markdown-rs@1.0.0-alpha.18...1.0.0-alpha.19

</details>

<details>
<summary>serde-rs/serde (serde)</summary>

###
[`v1.0.206`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.206)

[Compare
Source](https://togithub.com/serde-rs/serde/compare/v1.0.205...v1.0.206)

- Improve support for `flatten` attribute inside of enums
([#&#8203;2567](https://togithub.com/serde-rs/serde/issues/2567), thanks
[@&#8203;Mingun](https://togithub.com/Mingun))

###
[`v1.0.205`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.205)

[Compare
Source](https://togithub.com/serde-rs/serde/compare/v1.0.204...v1.0.205)

- Use serialize_entry instead of serialize_key + serialize_value when
serialize flattened newtype enum variants
([#&#8203;2785](https://togithub.com/serde-rs/serde/issues/2785), thanks
[@&#8203;Mingun](https://togithub.com/Mingun))
- Avoid triggering a collection_is_never_read lint in the
deserialization of enums containing flattened fields
([#&#8203;2791](https://togithub.com/serde-rs/serde/issues/2791))

</details>

<details>
<summary>Stebalien/tempfile (tempfile)</summary>

###
[`v3.12.0`](https://togithub.com/Stebalien/tempfile/blob/HEAD/CHANGELOG.md#3120)

- Add a `keep(keep: bool)` function to builder that suppresses
delete-on-drop behavior (thanks to
[@&#8203;RalfJung](https://togithub.com/RalfJung)).
-   Update `windows-sys` from 0.52 to 0.59.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10am on monday" in timezone
Asia/Shanghai, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/oxc-project/oxc).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet