Skip to content

Fix panic on incomplete closing frontmatter fence #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix panic on incomplete closing frontmatter fence #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/construct/document.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,14 +565,16 @@ fn resolve(tokenizer: &mut Tokenizer) {
inject_index = child_index + 1;
}

if let Some(mut exits) = tokenizer.tokenize_state.document_exits[line].take() {
let mut exit_index = 0;
while exit_index < exits.len() {
exits[exit_index].point = point.clone();
exit_index += 1;
if line < tokenizer.tokenize_state.document_exits.len() {
if let Some(mut exits) = tokenizer.tokenize_state.document_exits[line].take() {
let mut exit_index = 0;
while exit_index < exits.len() {
exits[exit_index].point = point.clone();
exit_index += 1;
}

child.map.add(inject_index, 0, exits);
}

child.map.add(inject_index, 0, exits);
}

line += 1;
Expand Down
6 changes: 6 additions & 0 deletions tests/frontmatter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ fn frontmatter() -> Result<(), message::Message> {
"should not support 2 markers in a closing fence"
);

assert_eq!(
to_html_with_options("---\n--\n", &frontmatter)?,
"<hr />\n<p>--</p>\n",
"should not panic if newline after 2 marker closing fence"
);

assert_eq!(
to_html_with_options("---\n----", &frontmatter)?,
"<hr />\n<hr />",
Expand Down