Fail requests on status code >= 400 #6383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ojisama
force-pushed
the
fail-on-non-2xx
branch
from
fef2cce to
ea4e375
Compare
Ojisama
force-pushed
the
fail-on-non-2xx
branch
from
ea4e375 to
fcf3633
Compare
|
Hey! Thanks for your work! I refactored part of the code to support this retry logic - please check #6413 if you have some time. I'm going to close this issue and the other to keep discussions on a single thread 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6359
Summary
Some commands (like
publish) do not fail if the response status code is >= 400.Test plan
Before
After
