Skip to content

Convert new version dialog to JavaFX #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Fixed the issue where import hangs for ris files with "ER - " failed #7737
merged 1 commit into from
Jan 23, 2019
Merged

Convert new version dialog to JavaFX #4602

merged 1 commit into from
Jan 23, 2019

Conversation

@tobiasdiez
Copy link
Member

image

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 22, 2019
@tobiasdiez tobiasdiez merged commit c6f68e3 into master Jan 23, 2019
@Siedlerchr Siedlerchr deleted the convertToFxmlSmall branch January 24, 2019 15:49
Siedlerchr added a commit that referenced this pull request Jan 24, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into convertDubplicate…
fc97929 
…tojavafx

* upstream/master:
  Fix not on FX thread exception
  Force javafx to run thread (#4604)
  Convert new version dialog to JavaFX (#4602)
Siedlerchr added a commit that referenced this pull request Jan 27, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into jdk9
0a54822 
* upstream/master: (229 commits)
  Try to fix not on FX thread for search and autocomplete (#4618)
  Convert DuplicateResolverDialog to javafx (#4601)
  Fix for BibTex source tab parsing issue if field contains {} (#4581)
  Convert OO/LO SidePanel to javafx (#4341)
  Convert "Customize importer" dialog to JavaFX (#4608)
  Convert "From Aux file" dialog to JavaFX (#4607)
  Convert "Show preferences" dialog to JavaFX (#4605)
  Fix not on FX thread exception
  Force javafx to run thread (#4604)
  Convert new version dialog to JavaFX (#4602)
  Add a variable to track the change in preview style (#4587)
  Solution for submitting dialog with Ctrl + Enter (#4496) (#4592)
  Bump mysql-connector-java from 8.0.13 to 8.0.14 (#4599)
  Fix overlapping font in id entry type (#4595)
  update jfoenix and gradle plugins Replace outdated transformer log4j2 with official new one
  Update journalList.txt
  Fix for Issue #4437 - Some bugs in preference->Entry table columns (#4546)
  Don't set column sort type at startup (#4577)
  Add uncaught exception message (#4565)
  Converts integrity check dialog to JavaFX (#4559)
  ...

# Conflicts:
#	build.gradle
#	src/main/java/org/jabref/gui/FindUnlinkedFilesDialog.java
#	src/main/java/org/jabref/gui/JabRefFrame.java
#	src/main/java/org/jabref/gui/fieldeditors/EditorTextArea.java
#	src/main/java/org/jabref/gui/fieldeditors/EditorTextField.java
#	src/main/java/org/jabref/gui/openoffice/CitationManager.java
#	src/main/java/org/jabref/gui/openoffice/OOBibBase.java
#	src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java
#	src/main/java/org/jabref/gui/openoffice/OpenOfficeSidePanel.java
Siedlerchr added a commit that referenced this pull request Feb 1, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into editStringsjavafx
c273ecb 
* upstream/master:
  Fix NPE and not on FX Thread in PreviewPrefs Tabs (#4624)
  Fix preview style configuration (#4613)
  Bump wiremock from 2.20.0 to 2.21.0 (#4623)
  snap: disable tests build, add removable media and specify architectures (#4619)
  Bump checkstyle from 8.16 to 8.17 (#4620)
  Fix preferences path: use _JAVA_OPTIONS
  Try to fix not on FX thread for search and autocomplete (#4618)
  Update snapcraft.yaml Move to snap folder
  Convert DuplicateResolverDialog to javafx (#4601)
  Fix for BibTex source tab parsing issue if field contains {} (#4581)
  Convert OO/LO SidePanel to javafx (#4341)
  Convert "Customize importer" dialog to JavaFX (#4608)
  Convert "From Aux file" dialog to JavaFX (#4607)
  Convert "Show preferences" dialog to JavaFX (#4605)
  Fix not on FX thread exception
  Force javafx to run thread (#4604)
  Convert new version dialog to JavaFX (#4602)
  Add a variable to track the change in preview style (#4587)
  Solution for submitting dialog with Ctrl + Enter (#4496) (#4592)
  Bump mysql-connector-java from 8.0.13 to 8.0.14 (#4599)

# Conflicts:
#	src/main/resources/l10n/JabRef_en.properties
github-actions bot pushed a commit that referenced this pull request Mar 21, 2020
Squashed 'src/main/resources/csl-styles/' changes from db8bd33..fa6bb22
4577cb9 
fa6bb22 Create quaternaire (#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (#4632)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fa6bb22
github-actions bot pushed a commit to augustjanse/jabref that referenced this pull request Mar 22, 2020
Squashed 'src/main/resources/csl-styles/' changes from 268df9e..fa6bb22
479874c 
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)
db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fa6bb22
github-actions bot pushed a commit to calixtus/jabref that referenced this pull request Mar 23, 2020
Squashed 'src/main/resources/csl-styles/' changes from 268df9e..7365ce8
5986c97 
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)
db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 7365ce8
github-actions bot pushed a commit to systemoperator/jabref that referenced this pull request Mar 26, 2020
Squashed 'src/main/resources/csl-styles/' changes from db8bd33..0cb6762
f8842d4 
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 0cb6762
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 268df9e..a51eb4f
f26b6ce 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)
db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from db8bd33..a51eb4f
9bdcdc8 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
github-actions bot pushed a commit to eetian/jabref that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 268df9e..a51eb4f
736d704 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)
db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
github-actions bot pushed a commit to abepolk/jabref that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 268df9e..a51eb4f
3c303db 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)
db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Apr 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 268df9e..a51eb4f
7d52068 
a51eb4f Create societe-francaise-detude-de-la-ceramique-antique-en-gaule.csl (JabRef#4653)
9032e5b Create geografia-fisica-e-dinamica-quaternaria.csl (JabRef#4650)
38996d6 Create multimed.csl (JabRef#4644)
9cd28d3 Update journal-of-urban-technology.csl (JabRef#4652)
265c93f Correct Acta Palaeontologica Polonica in-text citation format (JabRef#4655)
9cf9ddc Create bioscience.csl (JabRef#4654)
277f340 Update brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4656)
a3e4ecf Update associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#4461)
960b316 Create journal-of-urban-technology.csl (JabRef#4645)
ddf2572 Create universitat-stuttgart-mpp-standard.csl (JabRef#4639)
bde92d6 Update environmental-microbiology.csl (JabRef#4641)
efa68bc Update presses-universitaires-de-rennes.csl (JabRef#4640)
0872e3e Fixes JabRef#4648 (JabRef#4649)
9a159a4 Create studi-e-materiali-di-storia-delle-religioni.csl (JabRef#4642)
e63f13e further updates for websites and paper-conference Update ieee.csl (JabRef#4646)
0cb6762 Create Bulletin du Centre d’études médiévales d’Auxerre (JabRef#4635)
784a1c9 Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4634)
e5f9eed Update ieee.csl (JabRef#4636)
e82a783 Fix paper-conference in journal-of-new-zealand-grasslands.csl (JabRef#4637)
7365ce8 fix editor label for french apa.csl (JabRef#4616)
fa6bb22 Create quaternaire (JabRef#4602)
f2b4af4 Create the-journal-of-trauma-and-acute-care-surgery.csl (JabRef#4631)
0aa837e Update unified-style-sheet-for-linguistics.csl for "in" in chapters (JabRef#4632)
db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a51eb4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tobiasdiez @Siedlerchr