Fix for issue 6199: EndNote .xml import to JabRef: PDF links are not imported corrected.

[devinluo27]

Fixes #6199

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Summary of Issue 6199

When users import EndNote type xml to Jabref, it always assumes that urls are warped inside a style tag. However, some urls may not be wrapped in a style tag and as a result, Jabref cannot parses them.

Way to Fix

In the xsd file, I change the the complexType's attribute to mix="true", so that it can accept both vanilla text and subelements. Then I will check whether a style tag exists: if it does, use the text inside it; otherwise, use vanilla text instead.

[Siedlerchr]

Just a minor code improvement, but otherwise looks good to me!
That will benefit a lot of users!

[Siedlerchr]

Ah cool, did not know about this!

[devinluo27]

Yah, it's funny. I just knew that when I was looking up some relevant docs yesterday.

[koppor]

Does anyone know whether there is a globally updated "endnote.xsd"?

I am of the community believing that schema schecking is a good thing (json schema, xml schema, ...). (Side note: some say that even the schema should be sent along with the message: https://microservice-api-patterns.org/patterns/structure/elementStereotypes/MetadataElement#)

If a third party releases an schema for their data meaning that data produced by their software can be read in case it conforms to that schema, I would not try to change that schema.

Google lead me to https://forums.zotero.org/discussion/26493/endnote-xml-export-import - however, this his very outdated. Maybe, endnote.xsd is not maintained anymore and we can go ahead to create a fork?

I just wanted to double check.

[devinluo27]

Do you mean a globally standardized version of "endnote.xsd"?

I do not know much about it yet. But sending messages with its corresponding schema is indeed reasonable in order to parse the info correctedly.

[Siedlerchr]

Endnote only has a dtd not an xsd https://support.clarivate.com/Endnote/s/article/EndNote-XML-Document-Type-Definition?language=en_US
Seems like the xsd was somehow generated from an xml file. The xsd has been in JabRef since ages

[devinluo27]

Just a minor code improvement, but otherwise looks good to me!
That will benefit a lot of users!

I kind of messed up the previous commits. So I have incorporated your suggestion in the latest commit b1c3f75, please check.

[Siedlerchr]

@Aloofwisdom please have a look at the checkstyle test. You can also see the comments from reviewdog when you look at the Files changed tab

[devinluo27]

@Aloofwisdom please have a look at the checkstyle test. You can also see the comments from reviewdog when you look at the Files changed tab

I could pass the CheckStyle locally now. Please check again.

[Siedlerchr]

Thanks a lot for your contribution!