-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix for issue 6199: EndNote .xml import to JabRef: PDF links are not imported corrected. #7667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b1c3f75
Fix for issue 6199: EndNote .xml import to JabRef: PDF links are not …
devinluo27 3c28388
Merge branch 'main' into aloofwisdom-branch
Siedlerchr 4d2d2dd
fix issue #6199 finish checkstyle
devinluo27 5b6f806
Merge branch 'aloofwisdom-branch' of https://github.com/Aloofwisdom/j…
devinluo27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
...resources/org/jabref/logic/importer/fileformat/EndnoteXmlImporterTest_WithoutUrlStyle.bib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| @article{, | ||
| abstract = {test abstract}, | ||
| author = {Ahmad, AS and Ormiston-Smith, N and Sasieni, PD}, | ||
| doi = {10.1038/bjc.2014.606}, | ||
| file = {:file\://localhost/Users/user/Documents/Bookends/Attachments/Ahmad%20et%20al%202015.pdf:PDF}, | ||
| isbn = {1532-1827 (Electronic) 0007-0920 (Linking)}, | ||
| keywords = {Age Factors; Aged; Aged, 80 and over; Female; Great Britain/epidemiology; Humans; Male; Middle Aged; Models, Statistical; Neoplasms/*epidemiology; Risk Assessment; Risk Factors; Sex Characteristics}, | ||
| number = {5}, | ||
| pages = {943-7}, | ||
| title = {Trends in the lifetime risk of developing cancer in Great Britain: comparison of risk for those born from 1930 to 1960}, | ||
| volume = {112}, | ||
| year = {2015}, | ||
| journal = {Br J Cancer}, | ||
| note = {some notes}, | ||
| url = {http://www.ncbi.nlm.nih.gov/pubmed/25647015}, | ||
| } |
129 changes: 129 additions & 0 deletions
129
...resources/org/jabref/logic/importer/fileformat/EndnoteXmlImporterTest_WithoutUrlStyle.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <xml> | ||
| <records> | ||
| <record> | ||
| <database name="Library1.bdb" path="/Users/user/Documents/Bookends/Library1.bdb">Library1.bdb</database> | ||
| <source-app name="Bookends" version="13.0.5">Bookends</source-app> | ||
| <rec-number>2954</rec-number> | ||
| <ref-type name="Journal Article">17</ref-type> | ||
| <contributors> | ||
| <authors> | ||
| <author> | ||
| <style face="normal" size="100%">Ahmad, AS</style> | ||
| </author> | ||
| <author> | ||
| <style face="normal" size="100%">Ormiston-Smith, N</style> | ||
| </author> | ||
| <author> | ||
| <style face="normal" size="100%">Sasieni, PD</style> | ||
| </author> | ||
| </authors> | ||
| </contributors> | ||
| <auth-address> | ||
| <style face="normal" size="100%">Queen Mary University of London, Centre for Cancer Prevention, Wolfson | ||
| Institute of Preventive Medicine, Charterhouse Square, London EC1M 6BQ, UK.
Cancer Research UK, | ||
| Head of Statistical Information, Angel Building, 407 St John Street, London EC1V 4AD, UK. | ||
| </style> | ||
| </auth-address> | ||
| <titles> | ||
| <title> | ||
| <style face="normal" size="100%">Trends in the lifetime risk of developing cancer in Great Britain: | ||
| comparison of risk for those born from 1930 to 1960 | ||
| </style> | ||
| </title> | ||
| <secondary-title> | ||
| <style face="normal" size="100%">Br J Cancer</style> | ||
| </secondary-title> | ||
| </titles> | ||
| <pages> | ||
| <style face="normal" size="100%">943-7</style> | ||
| </pages> | ||
| <number> | ||
| <style face="normal" size="100%">5</style> | ||
| </number> | ||
| <volume> | ||
| <style face="normal" size="100%">112</style> | ||
| </volume> | ||
| <dates> | ||
| <year> | ||
| <style face="normal" size="100%">2015</style> | ||
| </year> | ||
| <pub-dates> | ||
| <date> | ||
| <style face="normal" size="100%">Mar 3</style> | ||
| </date> | ||
| </pub-dates> | ||
| </dates> | ||
| <keywords> | ||
| <keyword> | ||
| <style face="normal" size="100%">Age Factors</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Aged</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Aged, 80 and over</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Female</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Great Britain/epidemiology</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Humans</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Male</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Middle Aged</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Models, Statistical</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Neoplasms/*epidemiology</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Risk Assessment</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Risk Factors</style> | ||
| </keyword> | ||
| <keyword> | ||
| <style face="normal" size="100%">Sex Characteristics</style> | ||
| </keyword> | ||
| </keywords> | ||
| <abstract> | ||
| <style face="normal" size="100%">test abstract | ||
| </style> | ||
| </abstract> | ||
| <notes> | ||
| <style face="normal" size="100%">some notes | ||
| </style> | ||
| </notes> | ||
| <urls> | ||
| <related-urls> | ||
| <url> | ||
| <style face="normal" size="100%">http://www.ncbi.nlm.nih.gov/pubmed/25647015</style> | ||
| </url> | ||
| </related-urls> | ||
| <pdf-urls> | ||
| <url> | ||
| file://localhost/Users/user/Documents/Bookends/Attachments/Ahmad%20et%20al%202015.pdf | ||
| </url> | ||
| </pdf-urls> | ||
| </urls> | ||
| <isbn> | ||
| <style face="normal" size="100%">1532-1827 (Electronic)
0007-0920 (Linking)</style> | ||
| </isbn> | ||
| <electronic-resource-num> | ||
| <style face="normal" size="100%">10.1038/bjc.2014.606</style> | ||
| </electronic-resource-num> | ||
| <accession-num> | ||
| <style face="normal" size="100%">25647015</style> | ||
| </accession-num> | ||
| </record> | ||
| </records> | ||
| </xml> |
24 changes: 24 additions & 0 deletions
24
...esources/org/jabref/logic/importer/fileformat/EndnoteXmlImporterTest_WithoutUrlStyle2.bib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| @article{, | ||
| author = {Chapman, A. G.}, | ||
| isbn = {0012-9658}, | ||
| number = {1}, | ||
| pages = {93-105}, | ||
| title = {An ecological basis for reforestation of submariginal lands in the Central Hardwood Region}, | ||
| volume = {18}, | ||
| year = {1937}, | ||
| journal = {Ecology}, | ||
| note = {some notes}, | ||
| url = {<Go to ISI>://000200148800007} | ||
| } | ||
| @book{, | ||
| author = {Strohecker, H. F.}, | ||
| isbn = {0012-9658}, | ||
| number = {1}, | ||
| journal = {Ecology}, | ||
| note = {some other notes}, | ||
| pages = {162-168}, | ||
| title = {A survey of soil temperatures in the Chicago area}, | ||
| volume = {18}, | ||
| url = {<Go to ISI>://000200148800014}, | ||
| year = {1937} | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah cool, did not know about this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah, it's funny. I just knew that when I was looking up some relevant docs yesterday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone know whether there is a globally updated "endnote.xsd"?
I am of the community believing that schema schecking is a good thing (json schema, xml schema, ...). (Side note: some say that even the schema should be sent along with the message: https://microservice-api-patterns.org/patterns/structure/elementStereotypes/MetadataElement#)
If a third party releases an schema for their data meaning that data produced by their software can be read in case it conforms to that schema, I would not try to change that schema.
Google lead me to https://forums.zotero.org/discussion/26493/endnote-xml-export-import - however, this his very outdated. Maybe, endnote.xsd is not maintained anymore and we can go ahead to create a fork?
I just wanted to double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean a globally standardized version of "endnote.xsd"?
I do not know much about it yet. But sending messages with its corresponding schema is indeed reasonable in order to parse the info correctedly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Endnote only has a dtd not an xsd https://support.clarivate.com/Endnote/s/article/EndNote-XML-Document-Type-Definition?language=en_US
Seems like the xsd was somehow generated from an xml file. The xsd has been in JabRef since ages