Skip to content

Sync with master changes #16230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jan 4, 2023
Merged

Sync with master changes #16230

merged 21 commits into from
Jan 4, 2023

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 3, 2023 •
edited
Loading

What does this PR do?

git cherry-pick ca88f813a440bef61e611dc3c40343a2774cd21a..0716e73f18135e9c055fa0d095603e860b479200

Does your PR introduce any breaking changes? If yes, please list them.

None

cc @Borda

dmitsf and others added 13 commits January 3, 2023 16:43
@dmitsf @Borda
@awaelchli @carmocca
[App] Introduce basic auth to Lightning CLI (#16105)
b089f8c 
* Introduce basic auth to Lightning CLI for app creation

* Parsing creds added

* Adding auth field to app instance body

* Adding tests

* Adding changelog entry

* Adding more tests


* Update runtime.py

* Setting auth on update

* Fix test

* Update lightning-cloud dep

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>

* Update runtime.py

* Fix for release

* Update base.txt

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
@davidgilbertson @carmocca
docs: fix order of on_fit_start() hook (#16180)
c4547fe 
Fixes #16170
@ShashwatAgrawal20 @carmocca
docs: updated broken links (#16191)
bce415e 
Co-authored-by: Shashwat <shashwat>
Fixes #16186
@carmocca
Always use the local rank zero imports (#16178)
5e876f1
@nicolai86 @awaelchli @carmocca
update BYOC documentation with AWS details (#16044)
16ebbdf 
Co-authored-by: Adrian Wälchli <[email protected]>
@dmitsf @tchaton
@pre-commit-ci @carmocca
Using internal ip + port in a load balancer instead of URL exposed (#…
dc08e97 
…16119)

Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@carmocca
Remove CUDA_LAUNCH_BLOCKING from Lite tests (#16177)
6f3e8f9
@Borda @carmocca
simplify torch.Tensor (#16190)
3f2e559
@awaelchli @carmocca
Fix inclusion of model_parallel document (#16197)
58e6663 
fix link to gpu/advanced section
@dependabot @carmocca
Update numpy requirement from <1.23.1,>=1.17.2 to >=1.17.2,<1.24.1 in…
bf273e1 
… /requirements (#16199)

Update numpy requirement in /requirements

Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.17.2...v1.24.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @carmocca
Update s3fs requirement from <2022.8.3,>=2022.5.0 to >=2022.5.0,<2022…
968635c 
….11.1 in /requirements (#16198)

Update s3fs requirement in /requirements

Updates the requirements on [s3fs](https://github.com/fsspec/s3fs) to permit the latest version.
- [Release notes](https://github.com/fsspec/s3fs/releases)
- [Changelog](https://github.com/fsspec/s3fs/blob/main/release-procedure.md)
- [Commits](fsspec/s3fs@2022.5.0...2022.11.0)

---
updated-dependencies:
- dependency-name: s3fs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Borda @carmocca
ci: upload only with release (#16194)
1e627de
@dmitsf @carmocca
Update endpoint access examples: added info about accessing auth-prot…
9fbf82f 
…ected apps (#16145)
@carmocca carmocca self-assigned this Jan 3, 2023
@carmocca carmocca changed the base branch from master to lite/debug January 3, 2023 15:56
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023 •
edited
Loading

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning_fabric/fabric.py, src/lightning_fabric/plugins/environments/slurm.py, src/lightning_fabric/strategies/deepspeed.py, src/lightning_fabric/utilities/rank_zero.py, src/lightning_fabric/utilities/seed.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/pytorch_lightning/accelerators/accelerator.py, src/pytorch_lightning/callbacks/early_stopping.py, src/pytorch_lightning/callbacks/model_checkpoint.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/core/optimizer.py, src/pytorch_lightning/loggers/wandb.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/precision/colossalai.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/ipu.py, src/pytorch_lightning/plugins/precision/tpu.py, src/pytorch_lightning/profilers/pytorch.py, src/pytorch_lightning/strategies/colossalai.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/trainer/states.py, src/pytorch_lightning/utilities/data.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py, src/pytorch_lightning/utilities/model_summary/model_summary.py, src/pytorch_lightning/utilities/rank_zero.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/datasets.py, tests/tests_pytorch/helpers/deterministic_model.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/loops/test_evaluation_loop_flow.py, tests/tests_pytorch/loops/test_training_loop_flow_scalar.py, tests/tests_pytorch/models/test_gpu.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/plugins/precision/test_tpu.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/serve/test_servable_module_validator.py, tests/tests_pytorch/strategies/test_bagua_strategy.py, tests/tests_pytorch/strategies/test_hivemind.py, tests/tests_pytorch/strategies/test_sharded_strategy.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/utilities/migration/test_migration.py, tests/tests_pytorch/utilities/test_auto_restart.py, tests/tests_pytorch/utilities/test_fetching.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/pytorch_lightning/accelerators/accelerator.py, src/pytorch_lightning/callbacks/early_stopping.py, src/pytorch_lightning/callbacks/model_checkpoint.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/core/optimizer.py, src/pytorch_lightning/loggers/wandb.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/precision/colossalai.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/ipu.py, src/pytorch_lightning/plugins/precision/tpu.py, src/pytorch_lightning/profilers/pytorch.py, src/pytorch_lightning/strategies/colossalai.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/trainer/states.py, src/pytorch_lightning/utilities/data.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py, src/pytorch_lightning/utilities/model_summary/model_summary.py, src/pytorch_lightning/utilities/rank_zero.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/datasets.py, tests/tests_pytorch/helpers/deterministic_model.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/loops/test_evaluation_loop_flow.py, tests/tests_pytorch/loops/test_training_loop_flow_scalar.py, tests/tests_pytorch/models/test_gpu.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/plugins/precision/test_tpu.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/serve/test_servable_module_validator.py, tests/tests_pytorch/strategies/test_bagua_strategy.py, tests/tests_pytorch/strategies/test_hivemind.py, tests/tests_pytorch/strategies/test_sharded_strategy.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/utilities/migration/test_migration.py, tests/tests_pytorch/utilities/test_auto_restart.py, tests/tests_pytorch/utilities/test_fetching.py, requirements/fabric/base.txt, src/lightning_fabric/fabric.py, src/lightning_fabric/plugins/environments/slurm.py, src/lightning_fabric/strategies/deepspeed.py, src/lightning_fabric/utilities/rank_zero.py, src/lightning_fabric/utilities/seed.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
pytorch-lightning.Benchmark success ✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/examples.txt.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning_fabric/fabric.py, src/lightning_fabric/plugins/environments/slurm.py, src/lightning_fabric/strategies/deepspeed.py, src/lightning_fabric/utilities/rank_zero.py, src/lightning_fabric/utilities/seed.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/pytorch_lightning/accelerators/accelerator.py, src/pytorch_lightning/callbacks/early_stopping.py, src/pytorch_lightning/callbacks/model_checkpoint.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/core/optimizer.py, src/pytorch_lightning/loggers/wandb.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/precision/colossalai.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/ipu.py, src/pytorch_lightning/plugins/precision/tpu.py, src/pytorch_lightning/profilers/pytorch.py, src/pytorch_lightning/strategies/colossalai.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/trainer/states.py, src/pytorch_lightning/utilities/data.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py, src/pytorch_lightning/utilities/model_summary/model_summary.py, src/pytorch_lightning/utilities/rank_zero.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/datasets.py, tests/tests_pytorch/helpers/deterministic_model.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/loops/test_evaluation_loop_flow.py, tests/tests_pytorch/loops/test_training_loop_flow_scalar.py, tests/tests_pytorch/models/test_gpu.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/plugins/precision/test_tpu.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/serve/test_servable_module_validator.py, tests/tests_pytorch/strategies/test_bagua_strategy.py, tests/tests_pytorch/strategies/test_hivemind.py, tests/tests_pytorch/strategies/test_sharded_strategy.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/utilities/migration/test_migration.py, tests/tests_pytorch/utilities/test_auto_restart.py, tests/tests_pytorch/utilities/test_fetching.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning_fabric/fabric.py, src/lightning_fabric/plugins/environments/slurm.py, src/lightning_fabric/strategies/deepspeed.py, src/lightning_fabric/utilities/rank_zero.py, src/lightning_fabric/utilities/seed.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/pytorch_lightning/accelerators/accelerator.py, src/pytorch_lightning/callbacks/early_stopping.py, src/pytorch_lightning/callbacks/model_checkpoint.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/core/optimizer.py, src/pytorch_lightning/loggers/wandb.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/precision/colossalai.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/ipu.py, src/pytorch_lightning/plugins/precision/tpu.py, src/pytorch_lightning/profilers/pytorch.py, src/pytorch_lightning/strategies/colossalai.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/trainer/states.py, src/pytorch_lightning/utilities/data.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py, src/pytorch_lightning/utilities/model_summary/model_summary.py, src/pytorch_lightning/utilities/rank_zero.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/datasets.py, tests/tests_pytorch/helpers/deterministic_model.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/loops/test_evaluation_loop_flow.py, tests/tests_pytorch/loops/test_training_loop_flow_scalar.py, tests/tests_pytorch/models/test_gpu.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/plugins/precision/test_tpu.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/serve/test_servable_module_validator.py, tests/tests_pytorch/strategies/test_bagua_strategy.py, tests/tests_pytorch/strategies/test_hivemind.py, tests/tests_pytorch/strategies/test_sharded_strategy.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py, tests/tests_pytorch/utilities/migration/test_migration.py, tests/tests_pytorch/utilities/test_auto_restart.py, tests/tests_pytorch/utilities/test_fetching.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/pytorch_lightning/accelerators/accelerator.py, src/pytorch_lightning/callbacks/early_stopping.py, src/pytorch_lightning/callbacks/model_checkpoint.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/core/optimizer.py, src/pytorch_lightning/loggers/wandb.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/precision/colossalai.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/ipu.py, src/pytorch_lightning/plugins/precision/tpu.py, src/pytorch_lightning/profilers/pytorch.py, src/pytorch_lightning/strategies/colossalai.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/trainer/states.py, src/pytorch_lightning/utilities/data.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py, src/pytorch_lightning/utilities/model_summary/model_summary.py, src/pytorch_lightning/utilities/rank_zero.py, docs/source-pytorch/accelerators/gpu_advanced.rst, docs/source-pytorch/common/lightning_module.rst, requirements/pytorch/base.txt, requirements/pytorch/examples.txt.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.9, 1.10, 11.3.1) success ✅
build-cuda (3.9, 1.11, 11.3.1) success ✅
build-cuda (3.9, 1.12, 11.6.1) success ✅
build-cuda (3.9, 1.13, 11.6.1) success ✅
build-hpu (1.5.0, 1.11.0) success ✅
build-ipu (3.9, 1.10) success ✅
build-NGC success ✅
build-pl (3.9, 1.10, 11.3.1) success ✅
build-pl (3.9, 1.11, 11.3.1) success ✅
build-pl (3.9, 1.12, 11.6.1) success ✅
build-pl (3.9, 1.13, 11.6.1) success ✅
build-xla (3.7, 1.12) success ✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/fabric/base.txt.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, fabric, 3.8, 1.11) success ✅
fabric-cpu (macOS-11, fabric, 3.9, 1.12) success ✅
fabric-cpu (macOS-11, fabric, 3.10, 1.13) success ✅
fabric-cpu (macOS-11, fabric, 3.7, 1.10, oldest) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.7, 1.10, oldest) success ✅
fabric-cpu (windows-2022, fabric, 3.9, 1.11) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 1.12) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 1.13) success ✅
fabric-cpu (windows-2022, fabric, 3.7, 1.10, oldest) success ✅
fabric-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning_fabric/fabric.py, src/lightning_fabric/plugins/environments/slurm.py, src/lightning_fabric/strategies/deepspeed.py, src/lightning_fabric/utilities/rank_zero.py, src/lightning_fabric/utilities/seed.py, tests/tests_fabric/test_parity.py, tests/tests_fabric/utilities/test_apply_func.py, tests/tests_fabric/utilities/test_data.py, tests/tests_fabric/utilities/test_optimizer.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success ✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning_fabric/fabric.py, src/lightning_fabric/plugins/environments/slurm.py, src/lightning_fabric/strategies/deepspeed.py, src/lightning_fabric/utilities/rank_zero.py, src/lightning_fabric/utilities/seed.py, tests/tests_fabric/test_parity.py, tests/tests_fabric/utilities/test_apply_func.py, tests/tests_fabric/utilities/test_data.py, tests/tests_fabric/utilities/test_optimizer.py.

🔴 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success ✅
app-pytest (macOS-11, app, 3.8, oldest) success ✅
app-pytest (macOS-11, lightning, 3.9, latest) failure ❌
app-pytest (ubuntu-20.04, app, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.8, oldest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py, tests/tests_app/cli/test_run_app.py, tests/tests_app/runners/test_cloud.py, tests/tests_app/utilities/test_auth.py, requirements/app/base.txt, requirements/app/cloud.txt.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (macOS-11, app, 3.9, oldest) success ✅
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, oldest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py, requirements/app/base.txt, requirements/app/cloud.txt.

🔴 lightning_app: Azure
Check ID Status
App.cloud-e2e failure ❌

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py, requirements/app/base.txt, requirements/app/cloud.txt.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py, docs/source-app/workflows/byoc/aws_cli.rst, docs/source-app/workflows/byoc/aws_console.rst, docs/source-app/workflows/byoc/create_cluster.rst, docs/source-app/workflows/byoc/delete_cluster.rst, docs/source-app/workflows/byoc/index.rst, docs/source-app/workflows/byoc/run_on_cluster.rst, requirements/app/base.txt, requirements/app/cloud.txt.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/app/base.txt, requirements/app/cloud.txt, requirements/fabric/base.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py, src/lightning_fabric/fabric.py, src/lightning_fabric/plugins/environments/slurm.py, src/lightning_fabric/strategies/deepspeed.py, src/lightning_fabric/utilities/rank_zero.py, src/lightning_fabric/utilities/seed.py, src/pytorch_lightning/accelerators/accelerator.py, src/pytorch_lightning/callbacks/early_stopping.py, src/pytorch_lightning/callbacks/model_checkpoint.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/core/optimizer.py, src/pytorch_lightning/loggers/wandb.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/precision/colossalai.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/ipu.py, src/pytorch_lightning/plugins/precision/tpu.py, src/pytorch_lightning/profilers/pytorch.py, src/pytorch_lightning/strategies/colossalai.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/trainer/states.py, src/pytorch_lightning/utilities/data.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py, src/pytorch_lightning/utilities/model_summary/model_summary.py, src/pytorch_lightning/utilities/rank_zero.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.7) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.7) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.7) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.7) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.7) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.7) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/utilities/auth.py, src/lightning_fabric/fabric.py, src/lightning_fabric/plugins/environments/slurm.py, src/lightning_fabric/strategies/deepspeed.py, src/lightning_fabric/utilities/rank_zero.py, src/lightning_fabric/utilities/seed.py, src/pytorch_lightning/accelerators/accelerator.py, src/pytorch_lightning/callbacks/early_stopping.py, src/pytorch_lightning/callbacks/model_checkpoint.py, src/pytorch_lightning/core/module.py, src/pytorch_lightning/core/optimizer.py, src/pytorch_lightning/loggers/wandb.py, src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py, src/pytorch_lightning/loops/epoch/training_epoch_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/precision/colossalai.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/ipu.py, src/pytorch_lightning/plugins/precision/tpu.py, src/pytorch_lightning/profilers/pytorch.py, src/pytorch_lightning/strategies/colossalai.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/trainer/connectors/logger_connector/result.py, src/pytorch_lightning/trainer/states.py, src/pytorch_lightning/utilities/data.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py, src/pytorch_lightning/utilities/model_summary/model_summary.py, src/pytorch_lightning/utilities/rank_zero.py, requirements/app/base.txt, requirements/app/cloud.txt, requirements/fabric/base.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Jan 3, 2023
1SAA and others added 7 commits January 4, 2023 12:25
@1SAA @awaelchli @carmocca
Fix type error when dividing chunk size in colossalai strategy (#16212)
a36801c 
Co-authored-by: awaelchli <[email protected]>
@Liyang90 @awaelchli @carmocca
Fix DDP on XLA (#16020)
d8e3435 
Co-authored-by: awaelchli <[email protected]>
@manangoel99 @carmocca
Added support and test for custom artifact names in WandbLogger (#16173)
0fb5e39
@dependabot @carmocca
Update ipython[all] requirement from <8.6.1 to <8.7.1 in /requirements (
d9b5ce9 
#16220)

Updates the requirements on [ipython[all]](https://github.com/ipython/ipython) to permit the latest version.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@rel-0.8.4...8.7.0)

---
updated-dependencies:
- dependency-name: ipython[all]
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@awaelchli @justusschock @carmocca
Improvements to checkpoint migration (#16233)
83a2c9f 
Co-authored-by: Justus Schock <[email protected]>
@carmocca
Support arbitrary Optimizables as optimizers (#16189)
e403c35
@carmocca
Differences with master
ae5d360
@lexierule lexierule merged commit 174c32a into lite/debug Jan 4, 2023
@lexierule lexierule deleted the sync/lite-debug branch January 4, 2023 15:58
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca @dmitsf
@Borda @awaelchli @davidgilbertson @ShashwatAgrawal20 @nicolai86 @tchaton @pre-commit-ci @dependabot @1SAA @Liyang90 @manangoel99 @justusschock
Sync with master changes (#16230)
1e0720c 
* [App] Introduce basic auth to Lightning CLI (#16105)

* Introduce basic auth to Lightning CLI for app creation

* Parsing creds added

* Adding auth field to app instance body

* Adding tests

* Adding changelog entry

* Adding more tests


* Update runtime.py

* Setting auth on update

* Fix test

* Update lightning-cloud dep

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>

* Update runtime.py

* Fix for release

* Update base.txt

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>

* docs: fix order of on_fit_start() hook (#16180)

Fixes #16170

* docs: updated broken links (#16191)

Co-authored-by: Shashwat <shashwat>
Fixes #16186

* Always use the local rank zero imports (#16178)

* update BYOC documentation with AWS details (#16044)

Co-authored-by: Adrian Wälchli <[email protected]>

* Using internal ip + port in a load balancer instead of URL exposed (#16119)

Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Remove CUDA_LAUNCH_BLOCKING from Lite tests (#16177)

* simplify torch.Tensor (#16190)

* Fix inclusion of `model_parallel` document (#16197)

fix link to gpu/advanced section

* Update numpy requirement from <1.23.1,>=1.17.2 to >=1.17.2,<1.24.1 in /requirements (#16199)

Update numpy requirement in /requirements

Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.17.2...v1.24.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update s3fs requirement from <2022.8.3,>=2022.5.0 to >=2022.5.0,<2022.11.1 in /requirements (#16198)

Update s3fs requirement in /requirements

Updates the requirements on [s3fs](https://github.com/fsspec/s3fs) to permit the latest version.
- [Release notes](https://github.com/fsspec/s3fs/releases)
- [Changelog](https://github.com/fsspec/s3fs/blob/main/release-procedure.md)
- [Commits](fsspec/s3fs@2022.5.0...2022.11.0)

---
updated-dependencies:
- dependency-name: s3fs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: upload only with release (#16194)

* Update endpoint access examples: added info about accessing auth-protected apps (#16145)

* Skip a failing Bagua test for manual optimization (#16225)

* Fix type error when dividing chunk size in colossalai strategy (#16212)


Co-authored-by: awaelchli <[email protected]>

* Fix DDP on XLA (#16020)

Co-authored-by: awaelchli <[email protected]>

* Added support and test for custom artifact names in WandbLogger (#16173)

* Update ipython[all] requirement from <8.6.1 to <8.7.1 in /requirements (#16220)

Updates the requirements on [ipython[all]](https://github.com/ipython/ipython) to permit the latest version.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@rel-0.8.4...8.7.0)

---
updated-dependencies:
- dependency-name: ipython[all]
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Improvements to checkpoint migration (#16233)

Co-authored-by: Justus Schock <[email protected]>

* Support arbitrary `Optimizable`s as optimizers (#16189)

* Differences with master

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Dmitry Frolov <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: David Gilbertson <[email protected]>
Co-authored-by: Shashwat Agrawal <[email protected]>
Co-authored-by: Raphael Randschau <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: HELSON <[email protected]>
Co-authored-by: Liyang90 <[email protected]>
Co-authored-by: Manan Goel <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca @dmitsf
@Borda @awaelchli @davidgilbertson @ShashwatAgrawal20 @nicolai86 @tchaton @pre-commit-ci @dependabot @1SAA @Liyang90 @manangoel99 @justusschock
Sync with master changes (#16230)
f9b7936 
* [App] Introduce basic auth to Lightning CLI (#16105)

* Introduce basic auth to Lightning CLI for app creation

* Parsing creds added

* Adding auth field to app instance body

* Adding tests

* Adding changelog entry

* Adding more tests

* Update runtime.py

* Setting auth on update

* Fix test

* Update lightning-cloud dep

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>

* Update runtime.py

* Fix for release

* Update base.txt

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>

* docs: fix order of on_fit_start() hook (#16180)

Fixes #16170

* docs: updated broken links (#16191)

Co-authored-by: Shashwat <shashwat>
Fixes #16186

* Always use the local rank zero imports (#16178)

* update BYOC documentation with AWS details (#16044)

Co-authored-by: Adrian Wälchli <[email protected]>

* Using internal ip + port in a load balancer instead of URL exposed (#16119)

Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Remove CUDA_LAUNCH_BLOCKING from Lite tests (#16177)

* simplify torch.Tensor (#16190)

* Fix inclusion of `model_parallel` document (#16197)

fix link to gpu/advanced section

* Update numpy requirement from <1.23.1,>=1.17.2 to >=1.17.2,<1.24.1 in /requirements (#16199)

Update numpy requirement in /requirements

Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.17.2...v1.24.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update s3fs requirement from <2022.8.3,>=2022.5.0 to >=2022.5.0,<2022.11.1 in /requirements (#16198)

Update s3fs requirement in /requirements

Updates the requirements on [s3fs](https://github.com/fsspec/s3fs) to permit the latest version.
- [Release notes](https://github.com/fsspec/s3fs/releases)
- [Changelog](https://github.com/fsspec/s3fs/blob/main/release-procedure.md)
- [Commits](fsspec/s3fs@2022.5.0...2022.11.0)

---
updated-dependencies:
- dependency-name: s3fs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: upload only with release (#16194)

* Update endpoint access examples: added info about accessing auth-protected apps (#16145)

* Skip a failing Bagua test for manual optimization (#16225)

* Fix type error when dividing chunk size in colossalai strategy (#16212)

Co-authored-by: awaelchli <[email protected]>

* Fix DDP on XLA (#16020)

Co-authored-by: awaelchli <[email protected]>

* Added support and test for custom artifact names in WandbLogger (#16173)

* Update ipython[all] requirement from <8.6.1 to <8.7.1 in /requirements (#16220)

Updates the requirements on [ipython[all]](https://github.com/ipython/ipython) to permit the latest version.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@rel-0.8.4...8.7.0)

---
updated-dependencies:
- dependency-name: ipython[all]
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Improvements to checkpoint migration (#16233)

Co-authored-by: Justus Schock <[email protected]>

* Support arbitrary `Optimizable`s as optimizers (#16189)

* Differences with master

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Dmitry Frolov <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: David Gilbertson <[email protected]>
Co-authored-by: Shashwat Agrawal <[email protected]>
Co-authored-by: Raphael Randschau <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: HELSON <[email protected]>
Co-authored-by: Liyang90 <[email protected]>
Co-authored-by: Manan Goel <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justusschock justusschock justusschock approved these changes

@Borda Borda Awaiting requested review from Borda

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton

@lantiga lantiga Awaiting requested review from lantiga

@hhsecond hhsecond Awaiting requested review from hhsecond

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@akihironitta akihironitta Awaiting requested review from akihironitta

+1 more reviewer

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

ready PRs ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.