update BYOC documentation with AWS details #16044

nicolai86 · 2022-12-13T18:50:07Z

Update BYOC documentation

What does this PR do?

This PR adds details that must be public for customers to be able to create their own BYOC clusters.
They are technical in nature but since they are prerequisites for BYOC they must be documented.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

for more information, see https://pre-commit.ci

Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>

… in /requirements (#16107) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: thomas <[email protected]>

* change msg * update chgl * show the user's class name

* cold start proxy * Update src/lightning_app/components/serve/auto_scaler.py * changelog * better-doc Co-authored-by: Akihiro Nitta <[email protected]> Co-authored-by: thomas chaton <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>

* . * why * Revert "why" This reverts commit 375d3e8. * tried api access with fixed values * Revert "tried api access with fixed values" This reverts commit f1720f6. * Fix typo 🎉 * update chglog * revert removing lines in chlog * update chglog Co-authored-by: Akihiro Nitta <[email protected]>

github-actions · 2022-12-22T14:50:07Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to docs/source-app/workflows/byoc/aws_cli.rst, docs/source-app/workflows/byoc/aws_console.rst, docs/source-app/workflows/byoc/create_cluster.rst, docs/source-app/workflows/byoc/delete_cluster.rst, docs/source-app/workflows/byoc/index.rst, docs/source-app/workflows/byoc/run_on_cluster.rst.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

docs/source-app/workflows/byoc/create_cluster.rst

docs/source-app/workflows/byoc/run_on_cluster.rst

docs/source-app/workflows/byoc/aws_console.rst

docs/source-app/workflows/byoc/run_on_cluster.rst

docs/source-app/workflows/byoc/create_cluster.rst

Co-authored-by: Adrian Wälchli <[email protected]>

* [App] Introduce basic auth to Lightning CLI (#16105) * Introduce basic auth to Lightning CLI for app creation * Parsing creds added * Adding auth field to app instance body * Adding tests * Adding changelog entry * Adding more tests * Update runtime.py * Setting auth on update * Fix test * Update lightning-cloud dep * Apply suggestions from code review Co-authored-by: Adrian Wälchli <[email protected]> * Update runtime.py * Fix for release * Update base.txt Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> * docs: fix order of on_fit_start() hook (#16180) Fixes #16170 * docs: updated broken links (#16191) Co-authored-by: Shashwat <shashwat> Fixes #16186 * Always use the local rank zero imports (#16178) * update BYOC documentation with AWS details (#16044) Co-authored-by: Adrian Wälchli <[email protected]> * Using internal ip + port in a load balancer instead of URL exposed (#16119) Co-authored-by: thomas chaton <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Remove CUDA_LAUNCH_BLOCKING from Lite tests (#16177) * simplify torch.Tensor (#16190) * Fix inclusion of `model_parallel` document (#16197) fix link to gpu/advanced section * Update numpy requirement from <1.23.1,>=1.17.2 to >=1.17.2,<1.24.1 in /requirements (#16199) Update numpy requirement in /requirements Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v1.17.2...v1.24.0) --- updated-dependencies: - dependency-name: numpy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update s3fs requirement from <2022.8.3,>=2022.5.0 to >=2022.5.0,<2022.11.1 in /requirements (#16198) Update s3fs requirement in /requirements Updates the requirements on [s3fs](https://github.com/fsspec/s3fs) to permit the latest version. - [Release notes](https://github.com/fsspec/s3fs/releases) - [Changelog](https://github.com/fsspec/s3fs/blob/main/release-procedure.md) - [Commits](fsspec/s3fs@2022.5.0...2022.11.0) --- updated-dependencies: - dependency-name: s3fs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: upload only with release (#16194) * Update endpoint access examples: added info about accessing auth-protected apps (#16145) * Skip a failing Bagua test for manual optimization (#16225) * Fix type error when dividing chunk size in colossalai strategy (#16212) Co-authored-by: awaelchli <[email protected]> * Fix DDP on XLA (#16020) Co-authored-by: awaelchli <[email protected]> * Added support and test for custom artifact names in WandbLogger (#16173) * Update ipython[all] requirement from <8.6.1 to <8.7.1 in /requirements (#16220) Updates the requirements on [ipython[all]](https://github.com/ipython/ipython) to permit the latest version. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@rel-0.8.4...8.7.0) --- updated-dependencies: - dependency-name: ipython[all] dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Improvements to checkpoint migration (#16233) Co-authored-by: Justus Schock <[email protected]> * Support arbitrary `Optimizable`s as optimizers (#16189) * Differences with master Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Dmitry Frolov <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: David Gilbertson <[email protected]> Co-authored-by: Shashwat Agrawal <[email protected]> Co-authored-by: Raphael Randschau <[email protected]> Co-authored-by: thomas chaton <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HELSON <[email protected]> Co-authored-by: Liyang90 <[email protected]> Co-authored-by: Manan Goel <[email protected]> Co-authored-by: Justus Schock <[email protected]>

nicolai86 added 3 commits December 7, 2022 11:49

WIP

b32a2d7

Merge branch 'master' into nicolai86/ENG-1789

e1d9bd9

details about pre-requisites

eee2e7d

github-actions bot added the app (removed) Generic label for Lightning App package label Dec 13, 2022

nicolai86 and others added 20 commits December 13, 2022 10:52

warning about tag based cluster deletion

b39fcd4

some shoving around

a600f4c

mgmt

b7b2cbc

Merge branch 'master' into nicolai86/ENG-1789

2ed5185

Organize docs

e1fb215

[pre-commit.ci] auto fixes from pre-commit.com hooks

bc1da14

for more information, see https://pre-commit.ci

Add support for colossalai 0.1.11 (#15888)

ec5b791

Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>

Update scikit-learn requirement from <1.1.3,>0.22.1 to >0.22.1,<1.2.1…

29cb410

… in /requirements (#16107) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[App] update app testing (#16000)

2e5b307

Co-authored-by: thomas <[email protected]>

[App] Change overwrite to True (#16009)

3d62918

Co-authored-by: thomas <[email protected]>

[App] Improve PythonServer info message on startup (#15989)

113ce8c

* change msg * update chgl * show the user's class name

Remove the deprecated pl.loggers.base module (#16120)

04097e6

loggers: revert useless exception (#15789)

d09134d

update chlog after 1.8.5 (#16125)

40131a3

Deprecate nvidia/apex (#16039)

12e5ec9

Remove the deprecated Trainer.reset_train_val_dataloaders (#16131)

ae4e9cb

[App] Implement ready for components (#16129)

97c6db8

typos, small improvements

7c2ba3a

github-actions bot removed the app (removed) Generic label for Lightning App package label Dec 20, 2022

Merge branch 'master' into nicolai86/ENG-1789

9644e79

github-actions bot added the app (removed) Generic label for Lightning App package label Dec 20, 2022

nicolai86 added 2 commits December 20, 2022 15:36

more typos

5d1189b

link content

8503feb

nicolai86 marked this pull request as ready for review December 22, 2022 14:49

nicolai86 requested review from awaelchli, tchaton and williamFalcon as code owners December 22, 2022 14:49

nicolai86 changed the title ~~update BYOC documentation~~ update BYOC documentation with AWS details Dec 22, 2022

awaelchli approved these changes Dec 22, 2022

View reviewed changes

nicolai86 and others added 6 commits December 22, 2022 10:32

Update docs/source-app/workflows/byoc/aws_console.rst

0581148

Co-authored-by: Adrian Wälchli <[email protected]>

Update docs/source-app/workflows/byoc/create_cluster.rst

0fded19

Co-authored-by: Adrian Wälchli <[email protected]>

push cluster creation to step 3

b12ac8f

Update docs/source-app/workflows/byoc/run_on_cluster.rst

5c1dfe3

Co-authored-by: Adrian Wälchli <[email protected]>

Update docs/source-app/workflows/byoc/run_on_cluster.rst

87fa3d0

Co-authored-by: Adrian Wälchli <[email protected]>

Update docs/source-app/workflows/byoc/run_on_cluster.rst

52ef10c

Co-authored-by: Adrian Wälchli <[email protected]>

Borda approved these changes Dec 24, 2022

View reviewed changes

mergify bot added the ready PRs ready to be merged label Dec 24, 2022

Borda merged commit 5e1db28 into master Dec 24, 2022

Borda deleted the nicolai86/ENG-1789 branch December 24, 2022 03:35

carmocca pushed a commit that referenced this pull request Jan 3, 2023

update BYOC documentation with AWS details (#16044)

16ebbdf

Co-authored-by: Adrian Wälchli <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

update BYOC documentation with AWS details #16044

update BYOC documentation with AWS details #16044

Uh oh!

nicolai86 commented Dec 13, 2022 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Dec 22, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

update BYOC documentation with AWS details #16044

update BYOC documentation with AWS details #16044

Uh oh!

Conversation

nicolai86 commented Dec 13, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

Uh oh!

github-actions bot commented Dec 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡ Required checks status: All passing 🟢

Groups summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

nicolai86 commented Dec 13, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Dec 22, 2022 •

edited

Loading