-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: forward exceptions to Python and catch OOMs #4497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/bot run |
|
PR_Github #5897 [ run ] triggered by Bot |
|
PR_Github #5897 [ run ] completed with state |
|
/bot run |
|
PR_Github #6131 [ run ] triggered by Bot |
|
PR_Github #6131 [ run ] completed with state |
|
/bot run |
|
PR_Github #6256 [ run ] triggered by Bot |
|
/bot kill |
|
PR_Github #6271 [ kill ] triggered by Bot |
|
PR_Github #6256 [ run ] completed with state |
|
PR_Github #6271 [ kill ] completed with state |
|
/bot run |
|
PR_Github #6275 [ run ] triggered by Bot |
|
PR_Github #6275 [ run ] completed with state |
|
/bot run |
|
PR_Github #6453 [ run ] completed with state |
|
/bot run |
|
/bot kill |
|
PR_Github #6556 [ run ] triggered by Bot |
|
PR_Github #6559 [ kill ] triggered by Bot |
|
PR_Github #6556 [ run ] completed with state |
|
PR_Github #6559 [ kill ] completed with state |
|
/bot run |
|
PR_Github #6572 [ run ] triggered by Bot |
|
/bot kill |
|
PR_Github #6583 [ kill ] triggered by Bot |
|
PR_Github #6572 [ run ] completed with state |
|
PR_Github #6583 [ kill ] completed with state |
|
/bot run |
|
PR_Github #6588 [ run ] triggered by Bot |
|
PR_Github #6588 [ run ] completed with state |
|
/bot reuse-pipeline |
Signed-off-by: ixlmar <[email protected]>
|
PR_Github #6738 [ reuse-pipeline ] triggered by Bot |
|
/bot reuse-pipeline |
|
PR_Github #6748 [ reuse-pipeline ] triggered by Bot |
|
PR_Github #6748 [ reuse-pipeline ] completed with state |
Signed-off-by: ixlmar <[email protected]> Signed-off-by: darraghdog <[email protected]>
feat: forward exceptions to Python and catch OOMs
Description
This prints some additional information when
PyExecutorcreation fails due to insufficient GPU memory.Note: Commit 609e1bc is from PR #4493.
For instance, in the case that
ncclCommInitRankfails inAllgatherOp.initialize, the following error information is emitted.The message says might indicate, because the NCCL error text is "unhandled cuda error (run with NCCL_DEBUG=INFO for details)" and only running with
NCCL_DEBUG=WARNreveals:But currently there is no NCCL API to get this extra information (with
ncclCommInitRankfailing,ncclGetLastErrorcannot be used).Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.