Skip to content

Conversation

ixlmar
Copy link
Collaborator

@ixlmar ixlmar commented May 22, 2025

chore: introduce KvCacheCreator

Description

This is an attempt at giving more structure to the code in py_executor_creator.py and the associated _util.py.

Note: Commit b824e44394813ca17192c9ff3dfe8a52920f54ae is from pending PR #4497 and should no longer be part on this PR by the time it is merged.
Note: Commit deddf23bd3bcb9ced9976836dfb5f3f9282bcc5e is from pending PR #4574 and should no longer be part on this PR by the time it is merged.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@ixlmar
Copy link
Collaborator Author

ixlmar commented May 22, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6170 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6170 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4511 completed with status: 'FAILURE'

@ixlmar ixlmar force-pushed the chore/kv-cache-creator branch from 30be468 to dcd13e7 Compare May 23, 2025 06:58
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 23, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6258 [ run ] triggered by Bot

@ixlmar
Copy link
Collaborator Author

ixlmar commented May 23, 2025

/bot kill

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6267 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6258 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6267 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit dcd13e7

@ixlmar ixlmar force-pushed the chore/kv-cache-creator branch 2 times, most recently from a73a61b to 6916c67 Compare May 23, 2025 08:19
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 23, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6269 [ run ] triggered by Bot

@ixlmar
Copy link
Collaborator Author

ixlmar commented May 23, 2025

/bot kill

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6281 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6269 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6281 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit 6916c67

@ixlmar ixlmar force-pushed the chore/kv-cache-creator branch from 6916c67 to 649748c Compare May 26, 2025 12:09
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 26, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6478 [ run ] triggered by Bot

@ixlmar ixlmar force-pushed the chore/kv-cache-creator branch from 649748c to fd36978 Compare May 26, 2025 15:54
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 26, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6478 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4740 completed with status: 'FAILURE'

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6494 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6494 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4753 completed with status: 'FAILURE'

@ixlmar
Copy link
Collaborator Author

ixlmar commented May 27, 2025

/bot run

@ixlmar
Copy link
Collaborator Author

ixlmar commented May 27, 2025

/bot kill

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6554 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6558 [ kill ] triggered by Bot

@ixlmar ixlmar force-pushed the chore/kv-cache-creator branch from 1b4d4d5 to 88f0945 Compare May 30, 2025 10:03
@ixlmar ixlmar marked this pull request as draft May 30, 2025 10:06
@ixlmar ixlmar force-pushed the chore/kv-cache-creator branch from 88f0945 to ed2bf87 Compare May 30, 2025 10:11
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 30, 2025

/bot run

@ixlmar ixlmar marked this pull request as ready for review May 30, 2025 10:11
@ixlmar ixlmar marked this pull request as draft May 30, 2025 10:11
@tensorrt-cicd
Copy link
Collaborator

PR_Github #7069 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7069 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5115 completed with status: 'FAILURE'

@ixlmar
Copy link
Collaborator Author

ixlmar commented Jun 2, 2025

/bot run --disable-fail-fast --disable-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7205 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7205 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5217 (Partly Tested) completed with status: 'FAILURE'

@ixlmar ixlmar force-pushed the chore/kv-cache-creator branch from ed2bf87 to 7dcbef1 Compare June 2, 2025 17:46
@ixlmar
Copy link
Collaborator Author

ixlmar commented Jun 2, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7234 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7234 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5239 completed with status: 'FAILURE'

@ixlmar ixlmar force-pushed the chore/kv-cache-creator branch from 7dcbef1 to 6bf9232 Compare June 3, 2025 07:36
@ixlmar
Copy link
Collaborator Author

ixlmar commented Jun 3, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7301 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7301 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5291 completed with status: 'SUCCESS'

@ixlmar ixlmar marked this pull request as ready for review June 3, 2025 17:05
Copy link
Collaborator

@dcampora dcampora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor the function name, no need to rerun the CI.

@ixlmar ixlmar force-pushed the chore/kv-cache-creator branch from 6bf9232 to 527dbf7 Compare June 4, 2025 08:46
@ixlmar
Copy link
Collaborator Author

ixlmar commented Jun 4, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7478 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7478 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #7301 for commit 527dbf7

@dcampora dcampora merged commit 2bbb6b5 into NVIDIA:main Jun 4, 2025
3 checks passed
@ixlmar ixlmar deleted the chore/kv-cache-creator branch June 4, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants