Skip to content

Conversation

ixlmar
Copy link
Collaborator

@ixlmar ixlmar commented May 22, 2025

feat: estimate GPU mem. usage w/ minimal KV cache

Description

This improves the accuracy of the estimation of the GPU memory available for KV cache pages (cf. free_gpu_memory_fraction option) by performing the estimation with the smallest size possible initial KV cache.

Note: Commit b824e44394813ca17192c9ff3dfe8a52920f54ae is from pending PR #4497 and should no longer be part on this PR by the time it is merged.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@ixlmar
Copy link
Collaborator Author

ixlmar commented May 22, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6146 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6146 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4492 completed with status: 'FAILURE'

@ixlmar ixlmar force-pushed the feat/minimize-temporary-kv-cache branch from deddf23 to 5eed4c2 Compare May 23, 2025 06:57
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 23, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6257 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6257 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4573 completed with status: 'FAILURE'

@ixlmar ixlmar force-pushed the feat/minimize-temporary-kv-cache branch from 5eed4c2 to 6e623b2 Compare May 23, 2025 10:59
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 23, 2025

/bot run

@ixlmar
Copy link
Collaborator Author

ixlmar commented May 23, 2025

/bot kill

@ixlmar ixlmar force-pushed the feat/minimize-temporary-kv-cache branch from 6e623b2 to e10e7c7 Compare May 23, 2025 11:03
@tensorrt-cicd
Copy link
Collaborator

PR_Github #6289 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6290 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6289 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6290 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit e10e7c7

@ixlmar
Copy link
Collaborator Author

ixlmar commented May 23, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6291 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6291 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4598 completed with status: 'FAILURE'

@ixlmar
Copy link
Collaborator Author

ixlmar commented May 23, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6305 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6305 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4607 completed with status: 'FAILURE'

@ixlmar
Copy link
Collaborator Author

ixlmar commented May 23, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6313 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6313 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4613 completed with status: 'FAILURE'

@ixlmar ixlmar force-pushed the feat/minimize-temporary-kv-cache branch from e10e7c7 to 7800066 Compare May 26, 2025 12:06
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 26, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6476 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6476 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4738 completed with status: 'FAILURE'

@ixlmar
Copy link
Collaborator Author

ixlmar commented May 27, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6555 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6557 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit 7800066

@ixlmar ixlmar force-pushed the feat/minimize-temporary-kv-cache branch from 7800066 to 2144a5e Compare May 27, 2025 07:14
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 27, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6589 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6589 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4816 completed with status: 'SUCCESS'

@ixlmar ixlmar force-pushed the feat/minimize-temporary-kv-cache branch 2 times, most recently from 849ed9c to 7228d5f Compare May 28, 2025 08:17
@ixlmar ixlmar marked this pull request as ready for review May 28, 2025 08:17
@ixlmar ixlmar requested a review from a team as a code owner May 28, 2025 08:17
@ixlmar ixlmar requested a review from lfr-0531 May 28, 2025 08:17
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 28, 2025

/bot reuse-pipeline

@ixlmar ixlmar requested a review from dcampora May 28, 2025 08:22
@tensorrt-cicd
Copy link
Collaborator

PR_Github #6740 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6740 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #6589 for commit 7228d5f

@ixlmar ixlmar force-pushed the feat/minimize-temporary-kv-cache branch from 7228d5f to c1f5a57 Compare May 28, 2025 10:03
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 28, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6761 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6761 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #6589 for commit c1f5a57

@ixlmar ixlmar force-pushed the feat/minimize-temporary-kv-cache branch from c1f5a57 to 4ea7495 Compare May 30, 2025 08:24
@ixlmar ixlmar requested a review from dcampora May 30, 2025 08:25
@ixlmar
Copy link
Collaborator Author

ixlmar commented May 30, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7057 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7057 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #6589 for commit 4ea7495

@dcampora dcampora merged commit 7e6d06d into NVIDIA:main May 30, 2025
3 checks passed
@ixlmar ixlmar deleted the feat/minimize-temporary-kv-cache branch May 30, 2025 08:43
darraghdog pushed a commit to darraghdog/TensorRT-LLM that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants