-
-
Notifications
You must be signed in to change notification settings - Fork 116
[Vanilla Enhancement] Amphibious access vehicle #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CrimRecya
merged 46 commits into
Phobos-developers:develop
from
CrimRecya:develop-AmphibiousEnter
Apr 22, 2025
Merged
[Vanilla Enhancement] Amphibious access vehicle #1602
CrimRecya
merged 46 commits into
Phobos-developers:develop
from
CrimRecya:develop-AmphibiousEnter
Apr 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
CrimRecya
added a commit
that referenced
this pull request
Apr 1, 2025
- The fixes and new features are still being tested in #1602 , and only simplified code here.
Have split some of the fixes and can wait until the fixes are merged before paying attention to this pr. |
NetsuNegi
approved these changes
Apr 8, 2025
NetsuNegi
approved these changes
Apr 8, 2025
CrimRecya
added a commit
that referenced
this pull request
Apr 11, 2025
…1613) Phobos fix: Fixed an issue that passengers would not gather at the board position when the transport ship came to pick them up when `NoQueueUpToEnter` was enabled. Fixed an issue that overlap may still occur when `NoQueueUpToEnter` was enabled. Fixed an issue that the sound will continue to play if passengers are unable to unload all at once when `NoQueueUpToEnter` was enabled. Fixed an issue that foots will leave impassable invisible barrier when boarding vehicles on the bridge, which can later cause the game to freeze when `NoQueueUpToEnter` was enabled. Fixed an issue that foots under the bridge are allowed to board vehicles on the bridge when `NoQueueUpToEnter` was enabled. Vanilla fix: Fixed an issue that the first passenger who call the transport ship no longer board the transport ship when the land units call for boarding. Fixed an issue that impassable invisible barrier generated by the behavior of infantry continuously entering vehicles. Fixed an issue that teleport units board transport vehicles on the bridge will create an impassable invisible barrier, which may cause the game to freeze or even crash Splits from #1602 .
Coronia
pushed a commit
that referenced
this pull request
Apr 12, 2025
…1613) Phobos fix: Fixed an issue that passengers would not gather at the board position when the transport ship came to pick them up when `NoQueueUpToEnter` was enabled. Fixed an issue that overlap may still occur when `NoQueueUpToEnter` was enabled. Fixed an issue that the sound will continue to play if passengers are unable to unload all at once when `NoQueueUpToEnter` was enabled. Fixed an issue that foots will leave impassable invisible barrier when boarding vehicles on the bridge, which can later cause the game to freeze when `NoQueueUpToEnter` was enabled. Fixed an issue that foots under the bridge are allowed to board vehicles on the bridge when `NoQueueUpToEnter` was enabled. Vanilla fix: Fixed an issue that the first passenger who call the transport ship no longer board the transport ship when the land units call for boarding. Fixed an issue that impassable invisible barrier generated by the behavior of infantry continuously entering vehicles. Fixed an issue that teleport units board transport vehicles on the bridge will create an impassable invisible barrier, which may cause the game to freeze or even crash Splits from #1602 .
NetsuNegi
approved these changes
Apr 22, 2025
Coronia
pushed a commit
that referenced
this pull request
Oct 8, 2025
#1475 #1602 Extend their logic to the structure. --------- Co-authored-by: Fly-Star <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Fix and merge this
⚙️T1
T1 maintainer review is sufficient
Tested
❓Unhardcoding / Customization
Make something more tweakable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[General]->AmphibiousEnter
or[General]->AmphibiousUnload
.In
rulesmd.ini
: