Skip to content

Conversation

CrimRecya
Copy link
Contributor

@CrimRecya CrimRecya commented Apr 1, 2025

  • Now you can let amphibious infantry or vehicle passengers enter or leave amphibious transport vehicles on water surface. Defaults to [General]->AmphibiousEnter or [General]->AmphibiousUnload.

In rulesmd.ini:

[General]
AmphibiousEnter=false    ; boolean
AmphibiousUnload=false   ; boolean

[SOMEVEHICLE]            ; VehicleType
AmphibiousEnter=         ; boolean
AmphibiousUnload=        ; boolean

Copy link

github-actions bot commented Apr 1, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@TaranDahl TaranDahl added ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable labels Apr 1, 2025
CrimRecya added a commit that referenced this pull request Apr 1, 2025
- The fixes and new features are still being tested in #1602 , and only simplified code here.
@CrimRecya CrimRecya added the ❓Vanilla bug Vanilla game bugs that are requested to be fixed label Apr 2, 2025
@Coronia Coronia added the Tested label Apr 7, 2025
@Coronia Coronia requested a review from NetsuNegi April 7, 2025 02:58
@CrimRecya CrimRecya added Needs splitting The PR should be splitted into several separate standalone commits and removed ❓Vanilla bug Vanilla game bugs that are requested to be fixed labels Apr 7, 2025
@CrimRecya
Copy link
Contributor Author

Have split some of the fixes and can wait until the fixes are merged before paying attention to this pr.

CrimRecya added a commit that referenced this pull request Apr 11, 2025
…1613)

Phobos fix:
Fixed an issue that passengers would not gather at the board position
when the transport ship came to pick them up when `NoQueueUpToEnter` was
enabled.
Fixed an issue that overlap may still occur when `NoQueueUpToEnter` was
enabled.
Fixed an issue that the sound will continue to play if passengers are
unable to unload all at once when `NoQueueUpToEnter` was enabled.
Fixed an issue that foots will leave impassable invisible barrier when
boarding vehicles on the bridge, which can later cause the game to
freeze when `NoQueueUpToEnter` was enabled.
Fixed an issue that foots under the bridge are allowed to board vehicles
on the bridge when `NoQueueUpToEnter` was enabled.

Vanilla fix:
Fixed an issue that the first passenger who call the transport ship no
longer board the transport ship when the land units call for boarding.
Fixed an issue that impassable invisible barrier generated by the
behavior of infantry continuously entering vehicles.
Fixed an issue that teleport units board transport vehicles on the
bridge will create an impassable invisible barrier, which may cause the
game to freeze or even crash

Splits from #1602 .
@CrimRecya CrimRecya removed the Needs splitting The PR should be splitted into several separate standalone commits label Apr 11, 2025
Coronia pushed a commit that referenced this pull request Apr 12, 2025
…1613)

Phobos fix:
Fixed an issue that passengers would not gather at the board position
when the transport ship came to pick them up when `NoQueueUpToEnter` was
enabled.
Fixed an issue that overlap may still occur when `NoQueueUpToEnter` was
enabled.
Fixed an issue that the sound will continue to play if passengers are
unable to unload all at once when `NoQueueUpToEnter` was enabled.
Fixed an issue that foots will leave impassable invisible barrier when
boarding vehicles on the bridge, which can later cause the game to
freeze when `NoQueueUpToEnter` was enabled.
Fixed an issue that foots under the bridge are allowed to board vehicles
on the bridge when `NoQueueUpToEnter` was enabled.

Vanilla fix:
Fixed an issue that the first passenger who call the transport ship no
longer board the transport ship when the land units call for boarding.
Fixed an issue that impassable invisible barrier generated by the
behavior of infantry continuously entering vehicles.
Fixed an issue that teleport units board transport vehicles on the
bridge will create an impassable invisible barrier, which may cause the
game to freeze or even crash

Splits from #1602 .
@CrimRecya CrimRecya merged commit 674f78d into Phobos-developers:develop Apr 22, 2025
6 checks passed
@CrimRecya CrimRecya deleted the develop-AmphibiousEnter branch April 24, 2025 02:36
Coronia pushed a commit that referenced this pull request Oct 8, 2025
#1475
#1602

Extend their logic to the structure.

---------

Co-authored-by: Fly-Star <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix and merge this ⚙️T1 T1 maintainer review is sufficient Tested ❓Unhardcoding / Customization Make something more tweakable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants