Accept inverse_flattening = 0 for spherical ellipsoid (closes #4146) #4368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsbarring
force-pushed
the
fix_spherical_ellipsoid
branch
from
bac5024 to
930f3bc
Compare
|
Thanks for your contribution @larsbarring! I've added a test that failed without your addition, and passes with it. @bjlittle - would you mind giving this a once-over and if you're a happy then pressing the button? |
for more information, see https://pre-commit.ci
jamesp
approved these changes
Oct 13, 2021
bjlittle
reviewed
Oct 18, 2021
| # Perfect sphere (semi_major_axis only)? (1 0 0) | ||
| elif semi_major_axis is not None and ( | ||
| semi_minor_axis is None and inverse_flattening is None | ||
| semi_minor_axis is None and not inverse_flattening |
There was a problem hiding this comment.
This means that all of the following are now identical ellipsoid specifications for a sphere:
GeogCS(major_semi_axis=1.0, inverse_flattening=0)GeogCS(major_semi_axis=1.0, inverse_flattening=None)GeogCS(major_semi_axis=1.0)GeogCS(1.0)
I think that this new behaviour will be quite natural to users 👍
bjlittle
approved these changes
Oct 18, 2021
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Nov 3, 2021
* main: (44 commits) [pre-commit.ci] pre-commit autoupdate (SciTools#4395) min pin for numpy (nep29) (SciTools#4386) Updated environment lockfiles (SciTools#4393) Extend stock.mesh api (SciTools#4389) Updated environment lockfiles (SciTools#4388) Integrate ASV with Nox (SciTools#4378) NetCDF save - stream ALL lazy arrays. (SciTools#4375) adopt flake8 maccabe complexity metric (SciTools#4380) Accept inverse_flattening = 0 for spherical ellipsoid (closes SciTools#4146) (SciTools#4368) Updated environment lockfiles (SciTools#4379) Prevent warning in `test_Saver` (SciTools#4376) drop pyugrid in site.cfg (SciTools#4373) `flake8` dependency (SciTools#4371) update latest whosnew (SciTools#4372) Allow `check_graphic` to be more flexible (SciTools#4370) [pre-commit.ci] pre-commit autoupdate (SciTools#4365) Updated environment lockfiles (SciTools#4364) Update latest.rst (SciTools#4362) More clarity on setting `iris-test-data` location. (SciTools#4359) update whatsnew (SciTools#4361) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request