Extend stock.mesh api #4389
Merged
Extend stock.mesh api #4389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Oops.
Well, it will be true “shortly”
But probably not till after lunch now …
From: Martin Yeo ***@***.***>
Sent: 25 October 2021 12:17
To: SciTools/iris ***@***.***>
Cc: Peglar, Patrick ***@***.***>; Author ***@***.***>
Subject: Re: [SciTools/iris] Extend stock.mesh api (PR #4389)
This email was received from an external source. Always check sender details, links & attachments.
clearly the existing uses still work
Are you sure about that?<https://github.com/SciTools/iris/pull/4389/checks?check_run_id=3996060228>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#4389 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAP6A3KY54X2PUTLE5V6A3DUIU4DTANCNFSM5GU7YI6A>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
trexfeathers
requested changes
Oct 25, 2021
There was a problem hiding this comment.
Hi @pp-mo , assuming the tests pass this time 🤞, I just have two comments for your attention.
trexfeathers
approved these changes
Oct 25, 2021
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Nov 3, 2021
* main: (44 commits) [pre-commit.ci] pre-commit autoupdate (SciTools#4395) min pin for numpy (nep29) (SciTools#4386) Updated environment lockfiles (SciTools#4393) Extend stock.mesh api (SciTools#4389) Updated environment lockfiles (SciTools#4388) Integrate ASV with Nox (SciTools#4378) NetCDF save - stream ALL lazy arrays. (SciTools#4375) adopt flake8 maccabe complexity metric (SciTools#4380) Accept inverse_flattening = 0 for spherical ellipsoid (closes SciTools#4146) (SciTools#4368) Updated environment lockfiles (SciTools#4379) Prevent warning in `test_Saver` (SciTools#4376) drop pyugrid in site.cfg (SciTools#4373) `flake8` dependency (SciTools#4371) update latest whosnew (SciTools#4372) Allow `check_graphic` to be more flexible (SciTools#4370) [pre-commit.ci] pre-commit autoupdate (SciTools#4365) Updated environment lockfiles (SciTools#4364) Update latest.rst (SciTools#4362) More clarity on setting `iris-test-data` location. (SciTools#4359) update whatsnew (SciTools#4361) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added : optional edges/faces; lazy content; cube nomesh size control.
This is to support future work (WIP) in benchmarking ugrid saving.
There is no specific testing of these changes, as we usually avoid tests-of-tests
However, clearly the existing uses still work, and I can confirm that new features are working OK for me, elsewhere.