Prevent warning in test_Saver
#4376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
approved these changes
Oct 15, 2021
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Nov 3, 2021
* main: (44 commits) [pre-commit.ci] pre-commit autoupdate (SciTools#4395) min pin for numpy (nep29) (SciTools#4386) Updated environment lockfiles (SciTools#4393) Extend stock.mesh api (SciTools#4389) Updated environment lockfiles (SciTools#4388) Integrate ASV with Nox (SciTools#4378) NetCDF save - stream ALL lazy arrays. (SciTools#4375) adopt flake8 maccabe complexity metric (SciTools#4380) Accept inverse_flattening = 0 for spherical ellipsoid (closes SciTools#4146) (SciTools#4368) Updated environment lockfiles (SciTools#4379) Prevent warning in `test_Saver` (SciTools#4376) drop pyugrid in site.cfg (SciTools#4373) `flake8` dependency (SciTools#4371) update latest whosnew (SciTools#4372) Allow `check_graphic` to be more flexible (SciTools#4370) [pre-commit.ci] pre-commit autoupdate (SciTools#4365) Updated environment lockfiles (SciTools#4364) Update latest.rst (SciTools#4362) More clarity on setting `iris-test-data` location. (SciTools#4359) update whatsnew (SciTools#4361) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Aiming to fix #4374. Spliced a dictionary into the mocked api so that
fill_valueis afloatrather than aMagicMock.Another option would be to specify
fill_valuein the call tosaver.write(and updatecreate_var_callto match). That would be simpler, but I learned more by doing it this way 😆. Happy to change it.Consult Iris pull request check list