CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin… #540
Conversation
…d partial unusable disks and VM snapshots in secondary storage. Enhance storage garbage collector to delete corresponding partial disks created in secondary storage and VM snapshots while expunging 'ERROR' snapshot.
|
cloudstack-pull-requests #673 SUCCESS |
|
LGTM 👍 |
There was a problem hiding this comment.
Is this really only true for vmware? It seems that adding a uuid to the path is a rather universal action in the ssvm, no?
There was a problem hiding this comment.
It seems like it should be applied to any hypervisor.
Is that another one we can take in and fix?
|
This seems to me to be a solution for vmware for a more generic problem. in the generic code conditions for hypervisortype == vmware are set while the problem is generic over hypervisor typos. |
There was a problem hiding this comment.
I would also call concat twice: 1 for the "/"; and the 2nd time for the UUID.randomUUID().toString().
There was a problem hiding this comment.
auto spell typo? contact == concat
There was a problem hiding this comment.
Yep... I edited. :)
|
@likitha Any updates? |
|
Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-). |
This closes apache#577 This closes apache#566 This closes apache#562 This closes apache#561 This closes apache#556 This closes apache#555 This closes apache#554 This closes apache#548 This closes apache#544 This closes apache#540 This closes apache#508 This closes apache#384 This closes apache#372
This closes apache#577 This closes apache#566 This closes apache#562 This closes apache#561 This closes apache#556 This closes apache#555 This closes apache#554 This closes apache#548 This closes apache#544 This closes apache#540 This closes apache#384 This closes apache#372
This closes apache#577 This closes apache#566 This closes apache#562 This closes apache#561 This closes apache#556 This closes apache#555 This closes apache#554 This closes apache#548 This closes apache#544 This closes apache#540 This closes apache#384 This closes apache#372
|
tag:vmware-pickup |
|
@likitha is this PR still pertinent? |
|
@jburwell Likitha has moved on, unlikely we'll hear from her or see further development activity |
|
This is open to long with no progress |
|
@DaanHoogland while this is open with no progress, can you check if the issue has been fixed or there exists a PR that works towards fixing the same. Let's not close old PRs that might still be useful. |
|
Continued with the code changes here in a new PR #2090. |
…sl certs (#540) Co-authored-by: Pearl Dsilva <[email protected]> Signed-off-by: Rohit Yadav <[email protected]>
Fixes apache#540 Using a simple hyphen as a delimiter for config cache key can lead to ambiguity if the “name” field itself contains hyphens. To address this, a Ternary object of configkey name, scope and scope ID is used as the config cache keys. Signed-off-by: Abhishek Kumar <[email protected]>
8 participants
…d partial unusable disks and VM snapshots in secondary storage.
Enhance storage garbage collector to delete corresponding partial disks created in secondary storage and VM snapshots while expunging 'ERROR' snapshot.