Skip to content

Conversation

@pavanb018
Copy link
Contributor

Comments provided in PR 241 are addressed and the commits for those are in this PR.

@asfbot
Copy link

asfbot commented Jul 8, 2015

cloudstack-pull-rats #17 FAILURE
Looks like there's a problem with this pull request

@DaanHoogland
Copy link
Contributor

@pavanb018 You will have to add license headers to the new files

@asfbot
Copy link

asfbot commented Jul 8, 2015

cloudstack-pull-requests #712 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 8, 2015

cloudstack-pull-rats #19 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 8, 2015

cloudstack-pull-requests #714 SUCCESS
This pull request looks good

@pavanb018
Copy link
Contributor Author

test_project_private_template (integration.component.test_project_template.TestProjectPrivateTemplate) ... === TestName: test_project_private_template | Status : SUCCESS ===
ok


Ran 1 test in 216.074s

OK

@pavanb018
Copy link
Contributor Author

On Basic Zone:

Test Deploy Virtual Machine ... === TestName: test_deploy_vm_with_tags | Status : SUCCESS ===
ok


Ran 1 test in 34.365s

OK

@pavanb018
Copy link
Contributor Author

On Advanced Zone:

Test Deploy Virtual Machine ... === TestName: test_deploy_vm_with_tags | Status : SUCCESS ===
ok


Ran 1 test in 120.020s

OK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use validate list to validate list_volumes

@asfbot
Copy link

asfbot commented Jul 8, 2015

cloudstack-pull-rats #20 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 8, 2015

cloudstack-pull-rats #21 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 8, 2015

cloudstack-pull-requests #715 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 8, 2015

cloudstack-pull-requests #716 SUCCESS
This pull request looks good

@wido
Copy link
Contributor

wido commented Jul 17, 2015

I think it looks good? But it depends on earlier PR's I think since it's only a test

remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#508
This closes apache#384
This closes apache#372
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#384
This closes apache#372
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#384
This closes apache#372
@rodrigo93
Copy link
Contributor

Why does this PR still open? Shouldn't be closed? Seems that has been resolved already...

@pavanb018 pavanb018 closed this Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants