CLOUDSTACK-8611. CS waits indefinitely for CheckS2SVpnConnectionsComm… #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition.
|
cloudstack-pull-requests #689 SUCCESS |
Contributor
|
Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-). |
remibergsma
added a commit
to remibergsma/cloudstack
that referenced
this pull request
Aug 17, 2015
This closes apache#577 This closes apache#566 This closes apache#562 This closes apache#561 This closes apache#556 This closes apache#555 This closes apache#554 This closes apache#548 This closes apache#544 This closes apache#540 This closes apache#508 This closes apache#384 This closes apache#372
remibergsma
added a commit
to remibergsma/cloudstack
that referenced
this pull request
Aug 17, 2015
This closes apache#577 This closes apache#566 This closes apache#562 This closes apache#561 This closes apache#556 This closes apache#555 This closes apache#554 This closes apache#548 This closes apache#544 This closes apache#540 This closes apache#384 This closes apache#372
remibergsma
added a commit
to remibergsma/cloudstack
that referenced
this pull request
Aug 17, 2015
This closes apache#577 This closes apache#566 This closes apache#562 This closes apache#561 This closes apache#556 This closes apache#555 This closes apache#554 This closes apache#548 This closes apache#544 This closes apache#540 This closes apache#384 This closes apache#372
Member
|
Shouldn't the class throw a less generic Exception? A good choice might be the com.cloud.utils.ssh.SshException.SshException(String). |
Contributor
|
@GabrielBrascher If you want to work on this I suggest you pull in the pr branch and push it to your own clone to make a new PR. @likitha has left the community |
Member
|
That's fair enough @DaanHoogland, I will see what I can do for this PR. |
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 1, 2016
Continuing the work started by https://github.com/likitha cherry-pigking commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 1, 2016
Cherry-picked the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 4, 2016
Cherry-picked the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition. The SshHelper of the cherry picked commit is of another path from the current master, its path was https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java; thus, this commit brings that file changes, which at most were not made by me.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 4, 2016
Cherry-picked the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition. The SshHelper of the cherry picked commit is of another path from the current master, its path was https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java; thus, this commit brings that file changes, which at most were not made by me.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 5, 2016
Continued the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition. The SshHelper of the PR apache#561 is of another path from the current master, its path was https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java; thus, although this commit brings changes from PR apache#561, I did not cherry-picked to keep the master file, otherwise it would look that I had changed all the file. by me.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 7, 2016
Continued the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition. The SshHelper of the PR apache#561 is of another path from the current master, its path was https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java; thus, although this commit brings changes from PR apache#561, I did not cherry-picked to keep the master file, otherwise it would look that I had changed all the file. by me.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 7, 2016
Continued the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition. The SshHelper of the PR apache#561 is of another path from the current master, its path was https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java; thus, although this commit brings changes from PR apache#561, I did not cherry-picked to keep the master file, otherwise it would look that I had changed all the file. by me.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 7, 2016
Continued the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition. The SshHelper of the PR apache#561 is of another path from the current master, its path was https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java; thus, although this commit brings changes from PR apache#561, I did not cherry-picked to keep the master file, otherwise it would look that I had changed all the file. by me.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 7, 2016
Continued the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition. The SshHelper of the PR apache#561 is of another path from the current master, its path was https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java; thus, although this commit brings changes from PR apache#561, I did not cherry-picked to keep the master file, otherwise it would look that I had changed all the file. by me.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 8, 2016
Continued the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition. The SshHelper of the PR apache#561 is of another path from the current master, its path was https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java; thus, although this commit brings changes from PR apache#561, I did not cherry-picked to keep the master file, otherwise it would look that I had changed all the file. by me.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 8, 2016
Continued the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition. The SshHelper of the PR apache#561 is of another path from the current master, its path was https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java; thus, although this commit brings changes from PR apache#561, I did not cherry-picked to keep the master file, otherwise it would look that I had changed all the file. by me.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 9, 2016
Continued the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition. The SshHelper of the PR apache#561 is of another path from the current master, its path was https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java; thus, although this commit brings changes from PR apache#561, I did not cherry-picked to keep the master file, otherwise it would look that I had changed all the file. by me.
GabrielBrascher
pushed a commit
to GabrielBrascher/cloudstack
that referenced
this pull request
Apr 20, 2016
Continued the work started by https://github.com/likitha commit (b9181c6) from PR apache#561. CS waits indefinitely for CheckS2SVpnConnectionsComm and to return. While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition. The SshHelper of the PR apache#561 is of another path from the current master, its path was https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh/SshHelper.java; thus, although this commit brings changes from PR apache#561, I did not cherry-picked to keep the master file, otherwise it would look that I had changed all the file. by me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and to return.
While remote executing commands through ssh, handle channel condition of EOF because we wait for the the condition.
CheckS2SVpnConnectionsCommand execution involves executing a script (checkbatchs2svpn.sh) in the virtual router. Once CS has opened a session to a virtual router and executed a script in the router, it waits indefinitely till the session either times-out or the exit status of the remote process is available. But it is possible that an EOF is reached by the process in the router and the router never set the exit status.
References -
Hence if exit status is not set then the command will never return.