[microNPU] Cascader performance model bugfixes #10510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
jacobbohlin
force-pushed
the
cascader-perf-model-fixes
branch
from
3a54cf7 to
8745836
Compare
ekalda
reviewed
Mar 30, 2022
Contributor
ekalda
left a comment
ekalda
left a comment
There was a problem hiding this comment.
Thanks @jacobbohlin, one comment, otherwise looks good! :)
| min(output_shape[2] * output_shape[4], self._max_block_shape.depth), | ||
| min(output_shape[3], self._max_block_shape.width), | ||
| _round_up(min(output_shape[1], max_height), self._micro_block.height), | ||
| min(output_shape[2] * output_shape[4], max_width), |
Contributor
There was a problem hiding this comment.
Probably shouldn't take min with max_width
* Fixed incorrect num_blocks calculations for both BufferModes. * Fixed similar issues with Read/Write byte calculations. * Fixed an issue where the 'partkernel' flag was not propagated to the performance estimation code. * Fixed single buffering check incorrectly used output shape and block rather than the input shape and block. * Fixed block config not aligned to micro block for Elementwise. Change-Id: Ide6b231bc1a17c65bed20129d2179a215ada14b2
Changed incorrect usage of 'max_width' to 'max_depth'.
jacobbohlin
force-pushed
the
cascader-perf-model-fixes
branch
2 times, most recently
from
3a54cf7 to
07e7603
Compare
Contributor
|
Thanks @jacobbohlin @ekalda ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some bugs related to the microNPU performance model in the cascader.
This PR builds on and includes the changes in #10508 and will remain as a draft until that is merged.