Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Sep 30, 2019

Issue:
Fixes: #346

Description of changes:
Enabled github-codebuild-logs to make CodeBuild logs accessible
Refs: https://github.com/jlhood/github-codebuild-logs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixes: aws#346
Enabled github-codebuild-logs to make CodeBuild logs accessible
Refs: https://github.com/jlhood/github-codebuild-logs
@trivikr
Copy link
Member Author

trivikr commented Oct 1, 2019

The CodeBuild log from checks is not publicly viewable
The was no comment as documented in README of jlhood/github-codebuild-logs

@trivikr
Copy link
Member Author

trivikr commented Oct 1, 2019

The error in Cloudwatch is:

[ERROR] KeyError: 'auth'
Traceback (most recent call last):
  File "/var/task/processbuildevents.py", line 37, in handler
    GITHUB.publish_pr_comment(build)
  File "/var/task/github_proxy.py", line 47, in publish_pr_comment
    gh_client = self._get_client()
  File "/var/task/github_proxy.py", line 56, in _get_client
    self._init_client()
  File "/var/task/github_proxy.py", line 60, in _init_client
    self._init_github_info()
  File "/var/task/github_proxy.py", line 74, in _init_github_info
    if project_details['source']['auth']['type'] != 'OAUTH':

@trivikr
Copy link
Member Author

trivikr commented Oct 1, 2019

Following step from jlhood/github-codebuild-logs failed:

  • (4)(ii) publishes a comment on the GitHub PR with a publicly accessible link to the logs. Note, the app uses the CodeBuild project's GitHub OAUTH token to post the comment.

@trivikr
Copy link
Member Author

trivikr commented Oct 1, 2019

Related to jlhood/github-codebuild-logs#3

@trivikr
Copy link
Member Author

trivikr commented Oct 1, 2019

Added my personal access token with "write:discussion" permission instead of OAuth in CodeBuild.

The ['auth']['resource'] wasn't returned by

aws codebuild batch-get-projects --names sdk-staging-test

@trivikr
Copy link
Member Author

trivikr commented Oct 1, 2019

Deleted CloudFormation stack created by jlhood/github-codebuild-logs

Closing this PR

@trivikr trivikr closed this Oct 1, 2019
@trivikr trivikr deleted the remove-travis-ci branch October 1, 2019 01:09
@trivikr trivikr restored the remove-travis-ci branch October 1, 2019 05:36
@trivikr
Copy link
Member Author

trivikr commented Oct 1, 2019

The PR in which aws-cdk removed Travis CI aws/aws-cdk#4068

@trivikr trivikr mentioned this pull request Oct 3, 2019
@lock
Copy link

lock bot commented Oct 8, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Travis CI times out on PRs which impact 300+ packages

1 participant