Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Oct 3, 2019

Retry of #380 after setting token from aws-sdk-js-automation in our CodeBuild

Issue #, if available:
Fixes: #346

Description of changes:
Enabled github-codebuild-logs to make CodeBuild logs accessible
Refs: https://github.com/jlhood/github-codebuild-logs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixes: aws#346
Enabled github-codebuild-logs to make CodeBuild logs accessible
Refs: https://github.com/jlhood/github-codebuild-logs
@trivikr
Copy link
Member Author

trivikr commented Oct 3, 2019

Deployment of github-codebuild-logs failing
Issue created at jlhood/github-codebuild-logs#7

@AllanZhengYP
Copy link
Contributor

@trivikr Is this PR ready to merge?

@trivikr
Copy link
Member Author

trivikr commented Oct 4, 2019

Nope, still waiting for the feature request in jlhood/github-codebuild-logs#3

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member Author

trivikr commented Oct 9, 2019

The logs in #386 (comment) were publicly not accessible when I clicked on the comment soon after it was posted. But now they are accessible.
Restarting the build to see if that's always the case.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member Author

trivikr commented Oct 9, 2019

The build logs in #386 (comment) are publicly accessible.

@AllanZhengYP
Copy link
Contributor

Approved!

@lock
Copy link

lock bot commented Oct 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Travis CI times out on PRs which impact 300+ packages

3 participants