1.2.1 proposed #115
Merged
1.2.1 proposed #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 tasks
* some defaults should not be set using 'default' To implement the slightly complicated default value rules for ResourceRequirement * InputBinding.position default is 0. * File.streamable default is false.
also run the tests against cwltool
Changes it to reference another input parameter instead of using self. The behavior of processing secondary files patterns in order and being able to reference earlier ones later is not part of the spec. This doesn't exactly replicate the previous behavior, because it introduces a new input parameter, however it does demonstrate the ability to rename a file and have it staged as a secondary file without having to use InitialWorkDir. refs #127 Co-authored-by: Michael R. Crusoe <[email protected]>
* Address ambiguity on null and inputs.somearray.length in parameter reference * Clarify that the length field can sometimes apply to a non-array input
Courtesy of @nsoranzo
Test idea from @mvdbeek as part of the Galaxy CWL implementation
* validation warning won't be issued anymore Co-authored-by: Michael R. Crusoe <[email protected]>
|
StreamFlow passes all new Conformance tests. Nothing alarming in the CHANGELOG. For me, we can proceed. |
2 tasks
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.33.1 to 0.34.0. - [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases) - [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md) - [Commits](rojopolis/spellcheck-github-actions@0.33.1...0.34.0) --- updated-dependencies: - dependency-name: rojopolis/spellcheck-github-actions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
tetron
suggested changes
Oct 23, 2023
Co-authored-by: Peter Amstutz <[email protected]>
|
Closes crim-ca/weaver#549 |
tetron
previously approved these changes
Nov 6, 2023
|
All good from me 👍 |
mvdbeek
approved these changes
Nov 7, 2023
|
This pull request has been mentioned on Common Workflow Language Discourse. There might be relevant details there: https://cwl.discourse.group/t/cwl-v1-2-1-is-coming-soon/839/1 |
|
Looks Good For Me |
|
+1! |
|
Of the 10 members of the CWL Technical Team I see approvals from the following:
It isn't clear to me if Fabrice Brito has approved this. That's Assuming we don't hear any objection from @bogdang989 @fabricebrito |
|
Sorry for the delay. LGTM |
Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.34.0 to 0.35.0. - [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases) - [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md) - [Commits](rojopolis/spellcheck-github-actions@0.34.0...0.35.0) --- updated-dependencies: - dependency-name: rojopolis/spellcheck-github-actions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
|
@mr-c working on calrissian conformance tests this week. Will keep you posted. |
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
tetron
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A standing PR to see all the CWL v1.2.1 proposals that have gotten initial approval
https://deploy-preview-115--cwl-v1-2-dev.netlify.app/workflow#Changelog_for_v1.2.1
https://deploy-preview-115--cwl-v1-2-dev.netlify.app/commandlinetool#Changelog_for_v1.2.1