Skip to content

Conversation

klausi
Copy link
Contributor

@klausi klausi commented Sep 21, 2023

Follow-up from #911

rthideaway and others added 30 commits October 10, 2019 15:56
…l-graphql#1080)

* Fix notice about variables passed by reference

`reset` only takes variables so we can not pass the result of
`array_keys` directly but have to use an intermediate variable.

* Merge variable fallback expressions

`array_key_exists('schema', $input) ? $input['schema'] : NULL` is equal
to `$input['schema'] ?? NULL` on PHP versions that support the
null-coalescing operator. Since we already use this elsewhere we already
require such PHP versions.

This allows us to substitute the simplified one-use variable leading to
`$input['schema'] ?? NULL ?? $server->get('schema')`. The expression `??
NULL ??` can be safely transformed to `??` to result in the simplified
expression in this commit.

Co-authored-by: Klaus Purer <[email protected]>
klausi and others added 27 commits September 21, 2023 09:48
…se route config overrides entities in order to have consistency. (drupal-graphql#1304)
@klausi klausi merged commit 4452ea6 into drupal-graphql:8.x-4.x Sep 21, 2023
@klausi klausi deleted the entity-query branch September 21, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.