Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Dec 19, 2018

What does this PR do?

Fix #343 unhandled rejection on connect retry.

How should this be manually tested?

  • Step 1 : Run this snippet without Kuzzle running:
const {
  Kuzzle,
  Websocket
} = require('./index');

const
  websocketProtocol = new Websocket({ host: 'localhost', port: 7512 }),
  kuzzle = new Kuzzle(websocketProtocol);

  kuzzle.on('networkError', error => {
    console.error(`Network Error: ${error.message}`);
  });

(async () => {
  try {
    await kuzzle.connect();

    console.log(await kuzzle.server.now());
  } catch (error) {
    console.log(error);
  } finally {
    kuzzle.disconnect();
  }
})()

@Aschen Aschen changed the base branch from master to 6-dev December 19, 2018 13:55
@Aschen Aschen self-assigned this Dec 19, 2018
@codecov-io
Copy link

codecov-io commented Dec 19, 2018

Codecov Report

Merging #345 into 6-dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##            6-dev     #345   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          27       27           
  Lines        1397     1397           
=======================================
  Hits         1349     1349           
  Misses         48       48
Impacted Files Coverage Δ
src/protocols/abstract/realtime.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14ae29...f05e796. Read the comment docs.

@benoitvidis benoitvidis merged commit 8716be7 into 6-dev Dec 19, 2018
@Aschen Aschen mentioned this pull request Dec 27, 2018
Aschen added a commit that referenced this pull request Dec 27, 2018
Bug fixes

    [ #349 ] [build] Update webpack build config to fix raw web usage (Njuelle)
    [ #345 ] Fix 343 unhandled rejection on connect (Aschen)

Others

    [ #348 ] Put document:create optional args in last position (Aschen)
@Aschen Aschen mentioned this pull request Jan 7, 2019
Aschen added a commit that referenced this pull request Jan 7, 2019
#### Bug fixes

- [ [#349](#349) ] [build] Update webpack build config to fix raw web usage   ([Njuelle](https://github.com/Njuelle))
- [ [#345](#345) ] Fix 343 unhandled rejection on connect   ([Aschen](https://github.com/Aschen))

#### New features

- [ [#353](#353) ] Add method to use custom controllers in the SDK   ([Aschen](https://github.com/Aschen))

#### Enhancements

- [ [#350](#350) ] Have host param mandatory for protocols   ([Aschen](https://github.com/Aschen))

#### Others

- [ [#348](#348) ] Put document:create optional args in last position   ([Aschen](https://github.com/Aschen))
---
@scottinet scottinet mentioned this pull request Jan 17, 2019
scottinet pushed a commit that referenced this pull request Jan 17, 2019
Fix #343 unhandled rejection on connect retry.
@scottinet scottinet mentioned this pull request Jan 17, 2019
@scottinet scottinet deleted the fix-343-unhanlded-rejection-on-connect branch February 25, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants