Skip to content

[build] Update webpack build config to fix raw web usage #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 26, 2018
Merged

[build] Update webpack build config to fix raw web usage #349

merged 2 commits into from
Dec 26, 2018

Conversation

Njuelle
Copy link
Contributor

@Njuelle Njuelle commented Dec 26, 2018 •
edited
Loading

What does this PR do?

Update webpack build config to fix undefined protocol classes in raw web usage :

  • change webpack entrypoint to include all classes
  • rename library name to avoid Kuzzle.Kuzzle ...
  • add BUILT global constant to avoid exception when used in raw web

everything remains unchanged for use with Webpack and NodeJS

How should this be manually tested?

  • Checkout this branch
  • npm run build
  • create a test.html file at the root of the sdk-javascript folder with :
<!DOCTYPE html>
<html>
<head>
  <meta charset="utf-8" />
  <meta http-equiv="X-UA-Compatible" content="IE=edge">
  <title>Hello Kuzzle</title>
</head>
<body>
  <script src="dist/kuzzle.js"></script>
  <script>
    const kuzzle = new KuzzleSDK.Kuzzle(
      new KuzzleSDK.Websocket({ host: 'localhost' })
    );
    kuzzle.connect();
    kuzzle.addListener('connected', function() {
      console.log('Hello Kuzzle')
    });
  </script>
</body>
</html>
  • run a Kuzzle locally
  • try html file in your browser : file:///path/to/your/sdk-javascript/folder/test.html
  • look at the dev console

@Njuelle Njuelle self-assigned this Dec 26, 2018
@codecov-io
Copy link

codecov-io commented Dec 26, 2018 •
edited
Loading

Codecov Report

Merging #349 into 6-dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            6-dev     #349   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          27       27           
  Lines        1397     1397           
=======================================
  Hits         1349     1349           
  Misses         48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27fa579...4248cea. Read the comment docs.

@Njuelle Njuelle added 6-dev and removed wip labels Dec 26, 2018
@Aschen Aschen merged commit 7390dfb into 6-dev Dec 26, 2018
@Aschen Aschen deleted the fix-webpack-build branch December 26, 2018 17:26
@Aschen Aschen mentioned this pull request Dec 27, 2018
Merged
Aschen added a commit that referenced this pull request Dec 27, 2018
@Aschen
Release 6.0.0-beta-4 (#351)
9ee6f71 
Bug fixes

    [ #349 ] [build] Update webpack build config to fix raw web usage (Njuelle)
    [ #345 ] Fix 343 unhandled rejection on connect (Aschen)

Others

    [ #348 ] Put document:create optional args in last position (Aschen)
@Aschen Aschen mentioned this pull request Jan 7, 2019
Merged
Aschen added a commit that referenced this pull request Jan 7, 2019
@Aschen
6.0.0 beta 5 proposal (#354)
e35eb66 
#### Bug fixes

- [ [#349](#349) ] [build] Update webpack build config to fix raw web usage   ([Njuelle](https://github.com/Njuelle))
- [ [#345](#345) ] Fix 343 unhandled rejection on connect   ([Aschen](https://github.com/Aschen))

#### New features

- [ [#353](#353) ] Add method to use custom controllers in the SDK   ([Aschen](https://github.com/Aschen))

#### Enhancements

- [ [#350](#350) ] Have host param mandatory for protocols   ([Aschen](https://github.com/Aschen))

#### Others

- [ [#348](#348) ] Put document:create optional args in last position   ([Aschen](https://github.com/Aschen))
---
@scottinet scottinet mentioned this pull request Jan 17, 2019
Closed
scottinet pushed a commit that referenced this pull request Jan 17, 2019
@Njuelle @scottinet
[build] update webpack build config to fix raw web usage (#349)
cdef983 
Update webpack build config to fix undefined protocol classes in raw web usage :

    change webpack entrypoint to include all classes
    rename library name to avoid Kuzzle.Kuzzle ...
    add BUILT global constant to avoid exception when used in raw web

everything remains unchanged for use with Webpack and NodeJS
@scottinet scottinet mentioned this pull request Jan 17, 2019
Merged
@alexandrebouthinon alexandrebouthinon mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etrousset etrousset etrousset approved these changes

+1 more reviewer

@Aschen Aschen Aschen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Njuelle Njuelle

Labels

6-dev changelog:bug-fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Njuelle @codecov-io @Aschen @etrousset