Have host param mandatory for protocols #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
changed the title
Codecov Report
@@ Coverage Diff @@
## 6-dev #350 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 27 27
Lines 1397 1397
=======================================
Hits 1349 1349
Misses 48 48
Continue to review full report at Codecov.
|
etrousset
requested changes
Dec 27, 2018
Co-Authored-By: Aschen <[email protected]>
etrousset
approved these changes
Dec 27, 2018
Njuelle
approved these changes
Dec 27, 2018
etrousset
pushed a commit
to kuzzleio/documentation
that referenced
this pull request
Dec 27, 2018
Protocols host param is now mandatory and Websocket is renamed to WebSocket Depends on: kuzzleio/sdk-javascript#350
Merged
Aschen
added a commit
that referenced
this pull request
Jan 7, 2019
#### Bug fixes - [ [#349](#349) ] [build] Update webpack build config to fix raw web usage ([Njuelle](https://github.com/Njuelle)) - [ [#345](#345) ] Fix 343 unhandled rejection on connect ([Aschen](https://github.com/Aschen)) #### New features - [ [#353](#353) ] Add method to use custom controllers in the SDK ([Aschen](https://github.com/Aschen)) #### Enhancements - [ [#350](#350) ] Have host param mandatory for protocols ([Aschen](https://github.com/Aschen)) #### Others - [ [#348](#348) ] Put document:create optional args in last position ([Aschen](https://github.com/Aschen)) ---
Closed
scottinet
pushed a commit
that referenced
this pull request
Jan 17, 2019
The host param is now mandatory for protocols. The new constructor signature include mandatory host param and optional options param.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
hostparam is now mandatory for protocols. The new constructor signature include mandatoryhostparam and optionaloptionsparam.Documentation: kuzzleio/documentation#208
How should this be manually tested?
Other changes
WebsockettoWebSocket