Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Feb 24, 2021

What does this PR do?

Add a _source property containing the user custom content to match the API.

Fix #604

@Aschen Aschen self-assigned this Feb 24, 2021
@Aschen Aschen changed the base branch from master to 7-dev February 24, 2021 08:05
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #606 (73c6858) into 7-dev (9eaf648) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            7-dev     #606   +/-   ##
=======================================
  Coverage   86.54%   86.55%           
=======================================
  Files          33       33           
  Lines        1501     1502    +1     
  Branches      262      262           
=======================================
+ Hits         1299     1300    +1     
  Misses        149      149           
  Partials       53       53           
Impacted Files Coverage Δ
src/core/security/User.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eaf648...73c6858. Read the comment docs.

@Yoann-Abbes Yoann-Abbes merged commit 44f022d into 7-dev Mar 9, 2021
@Yoann-Abbes Yoann-Abbes deleted the 604-return-same-doc-structure-for-users branch March 9, 2021 09:00
@Aschen Aschen mentioned this pull request Apr 6, 2021
Aschen added a commit that referenced this pull request Apr 7, 2021
# [7.6.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.6.0) (2021-04-06)


#### Bug fixes

- [ [#622](#622) ] Pick first route when multiple non-GET routes of the same size are available   ([scottinet](https://github.com/scottinet))

#### New features

- [ [#621](#621) ] Secure WebSocket connection with cookie authentication   ([Shiranuit](https://github.com/Shiranuit))
- [ [#613](#613) ] Implement index:stats   ([Leodau](https://github.com/Leodau))
- [ [#612](#612) ] Implement security:getUserStrategies   ([Leodau](https://github.com/Leodau))

#### Enhancements

- [ [#620](#620) ] Add kuzzleStack property to KuzzleError   ([Aschen](https://github.com/Aschen))
- [ [#617](#617) ] Add suggest to search result   ([Aschen](https://github.com/Aschen))
- [ [#614](#614) ] Print deprecation warning from Kuzzle   ([MathieuVeber](https://github.com/MathieuVeber))
- [ [#606](#606) ] Add _source property to user objects   ([Aschen](https://github.com/Aschen))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Consistency] security:searchUsers method should return the same response than the one from the API
3 participants