-
Notifications
You must be signed in to change notification settings - Fork 17
Add kuzzleStack property to KuzzleError #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## 7-dev #620 +/- ##
=======================================
Coverage 86.77% 86.78%
=======================================
Files 34 34
Lines 1520 1521 +1
Branches 265 265
=======================================
+ Hits 1319 1320 +1
Misses 147 147
Partials 54 54
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think documentation is missing here https://docs.kuzzle.io/sdk/js/7/essentials/error-handling/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 , I think this file need an update too https://github.com/kuzzleio/sdk-javascript/blame/84795004abe50ab620f291563b582801681f20cb/doc/7/essentials/error-handling/index.md#L17
# [7.6.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.6.0) (2021-04-06) #### Bug fixes - [ [#622](#622) ] Pick first route when multiple non-GET routes of the same size are available ([scottinet](https://github.com/scottinet)) #### New features - [ [#621](#621) ] Secure WebSocket connection with cookie authentication ([Shiranuit](https://github.com/Shiranuit)) - [ [#613](#613) ] Implement index:stats ([Leodau](https://github.com/Leodau)) - [ [#612](#612) ] Implement security:getUserStrategies ([Leodau](https://github.com/Leodau)) #### Enhancements - [ [#620](#620) ] Add kuzzleStack property to KuzzleError ([Aschen](https://github.com/Aschen)) - [ [#617](#617) ] Add suggest to search result ([Aschen](https://github.com/Aschen)) - [ [#614](#614) ] Print deprecation warning from Kuzzle ([MathieuVeber](https://github.com/MathieuVeber)) - [ [#606](#606) ] Add _source property to user objects ([Aschen](https://github.com/Aschen)) ---
What does this PR do?
Add the
kuzzleStack
property containing the original stacktrace from Kuzzle.It will allow to display only the Kuzzle stacktrace when an error occurs (e.g. in Kourou the user does not care about the SDK stacktrace)