Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Mar 21, 2021

What does this PR do?

Add the kuzzleStack property containing the original stacktrace from Kuzzle.

It will allow to display only the Kuzzle stacktrace when an error occurs (e.g. in Kourou the user does not care about the SDK stacktrace)

@Aschen Aschen self-assigned this Mar 21, 2021
@Aschen Aschen changed the title Add kuzzleStack to error Add kuzzleStack property to KuzzleError Mar 21, 2021
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #620 (e26bbf8) into 7-dev (f1fb225) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e26bbf8 differs from pull request most recent head d88551d. Consider uploading reports for the commit d88551d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##            7-dev     #620   +/-   ##
=======================================
  Coverage   86.77%   86.78%           
=======================================
  Files          34       34           
  Lines        1520     1521    +1     
  Branches      265      265           
=======================================
+ Hits         1319     1320    +1     
  Misses        147      147           
  Partials       54       54           
Impacted Files Coverage Δ
src/KuzzleError.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1fb225...d88551d. Read the comment docs.

Copy link
Member

@alexandrebouthinon alexandrebouthinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think documentation is missing here https://docs.kuzzle.io/sdk/js/7/essentials/error-handling/

Copy link
Member

@alexandrebouthinon alexandrebouthinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leodau Leodau merged commit 9f19ef5 into 7-dev Mar 23, 2021
@Leodau Leodau deleted the add-kuzzle-stack branch March 23, 2021 17:39
@Aschen Aschen mentioned this pull request Apr 6, 2021
Aschen added a commit that referenced this pull request Apr 7, 2021
# [7.6.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.6.0) (2021-04-06)


#### Bug fixes

- [ [#622](#622) ] Pick first route when multiple non-GET routes of the same size are available   ([scottinet](https://github.com/scottinet))

#### New features

- [ [#621](#621) ] Secure WebSocket connection with cookie authentication   ([Shiranuit](https://github.com/Shiranuit))
- [ [#613](#613) ] Implement index:stats   ([Leodau](https://github.com/Leodau))
- [ [#612](#612) ] Implement security:getUserStrategies   ([Leodau](https://github.com/Leodau))

#### Enhancements

- [ [#620](#620) ] Add kuzzleStack property to KuzzleError   ([Aschen](https://github.com/Aschen))
- [ [#617](#617) ] Add suggest to search result   ([Aschen](https://github.com/Aschen))
- [ [#614](#614) ] Print deprecation warning from Kuzzle   ([MathieuVeber](https://github.com/MathieuVeber))
- [ [#606](#606) ] Add _source property to user objects   ([Aschen](https://github.com/Aschen))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants