Print deprecation warning from Kuzzle #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenow
approved these changes
Mar 10, 2021
Aschen
suggested changes
Mar 10, 2021
|
I don't see how the deprecation are hidden in production by default? |
If I understood well, usages of the console once the sdk is build are disabled, also it seems like Kuzzle server doesn't send deprecations info when turned in mode production. But I might not be the best to answer that @jenow @Yoann-Abbes |
Codecov Report
@@ Coverage Diff @@
## 7-dev #614 +/- ##
==========================================
+ Coverage 86.75% 86.80% +0.04%
==========================================
Files 33 34 +1
Lines 1503 1516 +13
Branches 262 265 +3
==========================================
+ Hits 1304 1316 +12
Misses 146 146
- Partials 53 54 +1
Continue to review full report at Codecov.
|
Aschen
reviewed
Mar 15, 2021
Aschen
suggested changes
Mar 15, 2021
+ Applying PR suggestions
Finally, using process.env.NODE_ENV was the solution to this issue |
Aschen
suggested changes
Mar 16, 2021
Aschen
suggested changes
Mar 16, 2021
Co-authored-by: Adrien Maret <[email protected]>
Aschen
approved these changes
Mar 16, 2021
MathieuVeber
changed the title
Merged
Aschen
added a commit
that referenced
this pull request
Apr 7, 2021
# [7.6.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.6.0) (2021-04-06) #### Bug fixes - [ [#622](#622) ] Pick first route when multiple non-GET routes of the same size are available ([scottinet](https://github.com/scottinet)) #### New features - [ [#621](#621) ] Secure WebSocket connection with cookie authentication ([Shiranuit](https://github.com/Shiranuit)) - [ [#613](#613) ] Implement index:stats ([Leodau](https://github.com/Leodau)) - [ [#612](#612) ] Implement security:getUserStrategies ([Leodau](https://github.com/Leodau)) #### Enhancements - [ [#620](#620) ] Add kuzzleStack property to KuzzleError ([Aschen](https://github.com/Aschen)) - [ [#617](#617) ] Add suggest to search result ([Aschen](https://github.com/Aschen)) - [ [#614](#614) ] Print deprecation warning from Kuzzle ([MathieuVeber](https://github.com/MathieuVeber)) - [ [#606](#606) ] Add _source property to user objects ([Aschen](https://github.com/Aschen)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #593
What does this PR do?
From now on, when developing with the SDK, you will see warning when using a deprecated action. You can disable this behavior by setting to false the deprecationWarning option on the kuzzle sdk object
How should this be manually tested?
Use a deprecated action and observe the warning(s)
Other changes
Updated doc and added tests