Tweak logging (log 500 requests), other small logging-adjacent tweaks
#161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamalama
force-pushed
the
improve-logging
branch
from
d390697 to
36a82a0
Compare
Contributor
bsieber-mozilla
left a comment
bsieber-mozilla
left a comment
There was a problem hiding this comment.
Thanks for this refactoring, I like the asgi.py addition!
leplatrem
reviewed
Jul 27, 2022
leplatrem
reviewed
Jul 27, 2022
grahamalama
force-pushed
the
improve-logging
branch
from
36a82a0 to
c2a3df1
Compare
- use new function to format fields
- use mozlog format for root handler - disable uvicorn access logs - pass config dict to Uvicorn Config
grahamalama
force-pushed
the
improve-logging
branch
from
c2a3df1 to
814f53c
Compare
grahamalama
changed the title
500 requests), other small logging-adjacent tweaks
grahamalama
commented
Jul 28, 2022
leplatrem
approved these changes
Jul 28, 2022
Contributor
leplatrem
left a comment
leplatrem
left a comment
There was a problem hiding this comment.
Output of make start looks sound! Great 🎉 Congrats and thanks for being so thorough. Result is super clean 💯
I also tested manually, the backoff logs are showing up:
{"Timestamp": 1659027658763760896, "Type": "backoff", "Logger": "jbi", "Hostname": "ESMAD0166L.transformabcn.com", "EnvVersion": "2.0", "Severity": 6, "Pid": 38891, "Fields": {"msg": "Backing off wrapped_func(...) for 0.6s (bugzilla.exceptions.BugzillaError: boom)"}}
{"Timestamp": 1659027659371533056, "Type": "backoff", "Logger": "jbi", "Hostname": "ESMAD0166L.transformabcn.com", "EnvVersion": "2.0", "Severity": 6, "Pid": 38891, "Fields": {"msg": "Backing off wrapped_func(...) for 0.9s (bugzilla.exceptions.BugzillaError: boom)"}}
{"Timestamp": 1659027660277774080, "Type": "backoff", "Logger": "jbi", "Hostname": "ESMAD0166L.transformabcn.com", "EnvVersion": "2.0", "Severity": 6, "Pid": 38891, "Fields": {"msg": "Backing off wrapped_func(...) for 2.5s (bugzilla.exceptions.BugzillaError: boom)"}}
{"Timestamp": 1659027662731826944, "Type": "backoff", "Logger": "jbi", "Hostname": "ESMAD0166L.transformabcn.com", "EnvVersion": "2.0", "Severity": 3, "Pid": 38891, "Fields": {"msg": "Giving up wrapped_func(...) after 4 tries (bugzilla.exceptions.BugzillaError: boom)"}}
Closed
leplatrem
added a commit
that referenced
this pull request
Aug 1, 2022
**Bug Fixes** - Retrieve comments from the API if they are private (fixes #154) (#163) **New Features** - Show 'Bug XXXX' instead of Bugzilla Ticket in Jira link (#159) - Add Jira details to log context (#157) - Retry Jira and Bugzilla on error (fixes #33) (#152) - Add counter and timer for action execution (fixes #23, #62, #160, #164) - Tweak logging (log `500` requests), other logging-adjacent tweaks (#161) **Configuration** - Use JB instead of OSS in config.prod.yaml and config.nonprod.yaml (#151, #153) - Add local config for tests (fixes #121) (#138) **Documentation** - Start (naive) troubleshooting section in README (#156) **Internal Changes** - Run app as a single uvicorn process (fixes #133) (#162) - Move initialized action callable to private field (#145) - Do not sleep in retry tests (#158) - Bump sentry-sdk from 1.8.0 to 1.9.0 (#167) - Bump yamllint from 1.26.3 to 1.27.1 (#166) - Bump atlassian-python-api from 3.20.1 to 3.25.0 (#149) - Bump dockerflow from 2022.1.0 to 2022.7.0 (#147) - Bump sentry-sdk from 1.7.2 to 1.8.0 (#146) - Bump detect-secrets from 1.2.0 to 1.3.0 (#148) - Bump mypy from 0.910 to 0.971 (#150)
Merged
leplatrem
added a commit
that referenced
this pull request
Aug 1, 2022
**Bug Fixes** - Retrieve comments from the API if they are private (fixes #154) (#163) **New Features** - Show 'Bug XXXX' instead of Bugzilla Ticket in Jira link (#159) - Add Jira details to log context (#157) - Retry Jira and Bugzilla on error (fixes #33) (#152) - Add counter and timer for action execution (fixes #23, #62, #160, #164) - Tweak logging (log `500` requests), other logging-adjacent tweaks (#161) **Configuration** - Use JB instead of OSS in config.prod.yaml and config.nonprod.yaml (#151, #153) - Add local config for tests (fixes #121) (#138) **Documentation** - Start (naive) troubleshooting section in README (#156) **Internal Changes** - Run app as a single uvicorn process (fixes #133) (#162) - Move initialized action callable to private field (#145) - Do not sleep in retry tests (#158) - Bump sentry-sdk from 1.8.0 to 1.9.0 (#167) - Bump yamllint from 1.26.3 to 1.27.1 (#166) - Bump atlassian-python-api from 3.20.1 to 3.25.0 (#149) - Bump dockerflow from 2022.1.0 to 2022.7.0 (#147) - Bump sentry-sdk from 1.7.2 to 1.8.0 (#146) - Bump detect-secrets from 1.2.0 to 1.3.0 (#148) - Bump mypy from 0.910 to 0.971 (#150) - Bump fastapi from 0.73.0 to 0.79.0 (#168)
grahamalama
added a commit
that referenced
this pull request
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits and the final product of this PR are definitely in a WIP state, but I'd like feedback now to make sure we're on the right path for our logging config.