Skip to content

Conversation

@leplatrem
Copy link
Contributor

Fixes #133

This could wait the asgi.py module from #161

@leplatrem leplatrem requested a review from a team as a code owner July 28, 2022 09:52
Copy link
Contributor

@bsieber-mozilla bsieber-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

👋 g🦄

@bsieber-mozilla
Copy link
Contributor

Fixes #133

This could wait the asgi.py module from #161

I think since the referenced PR has been merged there might need to be a change to this PR.

@leplatrem leplatrem merged commit a2ab57c into main Jul 29, 2022
@leplatrem leplatrem deleted the 133-remove-gunicorn branch July 29, 2022 08:02
leplatrem added a commit that referenced this pull request Aug 1, 2022
**Bug Fixes**

- Retrieve comments from the API if they are private (fixes #154) (#163)

**New Features**

- Show 'Bug XXXX' instead of Bugzilla Ticket in Jira link (#159)
- Add Jira details to log context (#157)
- Retry Jira and Bugzilla on error (fixes #33)  (#152)
- Add counter and timer for action execution (fixes #23, #62, #160, #164)
- Tweak logging (log `500` requests), other logging-adjacent tweaks (#161)

**Configuration**

- Use JB instead of OSS in config.prod.yaml and config.nonprod.yaml (#151, #153)
- Add local config for tests (fixes #121) (#138)

**Documentation**

- Start (naive) troubleshooting section in README (#156)

**Internal Changes**

- Run app as a single uvicorn process (fixes #133) (#162)
- Move initialized action callable to private field (#145)
- Do not sleep in retry tests (#158)

- Bump sentry-sdk from 1.8.0 to 1.9.0 (#167)
- Bump yamllint from 1.26.3 to 1.27.1 (#166)
- Bump atlassian-python-api from 3.20.1 to 3.25.0 (#149)
- Bump dockerflow from 2022.1.0 to 2022.7.0 (#147)
- Bump sentry-sdk from 1.7.2 to 1.8.0 (#146)
- Bump detect-secrets from 1.2.0 to 1.3.0 (#148)
- Bump mypy from 0.910 to 0.971 (#150)
@leplatrem leplatrem mentioned this pull request Aug 1, 2022
@leplatrem leplatrem added the enhancement New feature or request label Aug 1, 2022
leplatrem added a commit that referenced this pull request Aug 1, 2022
**Bug Fixes**

- Retrieve comments from the API if they are private (fixes #154) (#163)

**New Features**

- Show 'Bug XXXX' instead of Bugzilla Ticket in Jira link (#159)
- Add Jira details to log context (#157)
- Retry Jira and Bugzilla on error (fixes #33)  (#152)
- Add counter and timer for action execution (fixes #23, #62, #160, #164)
- Tweak logging (log `500` requests), other logging-adjacent tweaks (#161)

**Configuration**

- Use JB instead of OSS in config.prod.yaml and config.nonprod.yaml (#151, #153)
- Add local config for tests (fixes #121) (#138)

**Documentation**

- Start (naive) troubleshooting section in README (#156)

**Internal Changes**

- Run app as a single uvicorn process (fixes #133) (#162)
- Move initialized action callable to private field (#145)
- Do not sleep in retry tests (#158)

- Bump sentry-sdk from 1.8.0 to 1.9.0 (#167)
- Bump yamllint from 1.26.3 to 1.27.1 (#166)
- Bump atlassian-python-api from 3.20.1 to 3.25.0 (#149)
- Bump dockerflow from 2022.1.0 to 2022.7.0 (#147)
- Bump sentry-sdk from 1.7.2 to 1.8.0 (#146)
- Bump detect-secrets from 1.2.0 to 1.3.0 (#148)
- Bump mypy from 0.910 to 0.971 (#150)
- Bump fastapi from 0.73.0 to 0.79.0 (#168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run app as a single process in production

3 participants