Skip to content

Conversation

@Mossop
Copy link
Member

@Mossop Mossop commented Jul 28, 2022

No description provided.

@Mossop Mossop requested a review from a team as a code owner July 28, 2022 11:07
@Mossop Mossop force-pushed the private-comments branch from 7916840 to 38a5430 Compare July 28, 2022 13:59
@Mossop
Copy link
Member Author

Mossop commented Jul 28, 2022

Ok I think this is ready for review again then?

Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Having #140 would help here because calls to get_bugzilla() take time (authentication)

@Mossop Mossop force-pushed the private-comments branch from 38a5430 to 2a18a4f Compare July 28, 2022 15:11
@Mossop Mossop force-pushed the private-comments branch from 2a18a4f to b47ed38 Compare July 28, 2022 15:29
@leplatrem leplatrem merged commit fafc484 into mozilla:main Jul 28, 2022
@leplatrem
Copy link
Contributor

🎉

leplatrem added a commit that referenced this pull request Aug 1, 2022
**Bug Fixes**

- Retrieve comments from the API if they are private (fixes #154) (#163)

**New Features**

- Show 'Bug XXXX' instead of Bugzilla Ticket in Jira link (#159)
- Add Jira details to log context (#157)
- Retry Jira and Bugzilla on error (fixes #33)  (#152)
- Add counter and timer for action execution (fixes #23, #62, #160, #164)
- Tweak logging (log `500` requests), other logging-adjacent tweaks (#161)

**Configuration**

- Use JB instead of OSS in config.prod.yaml and config.nonprod.yaml (#151, #153)
- Add local config for tests (fixes #121) (#138)

**Documentation**

- Start (naive) troubleshooting section in README (#156)

**Internal Changes**

- Run app as a single uvicorn process (fixes #133) (#162)
- Move initialized action callable to private field (#145)
- Do not sleep in retry tests (#158)

- Bump sentry-sdk from 1.8.0 to 1.9.0 (#167)
- Bump yamllint from 1.26.3 to 1.27.1 (#166)
- Bump atlassian-python-api from 3.20.1 to 3.25.0 (#149)
- Bump dockerflow from 2022.1.0 to 2022.7.0 (#147)
- Bump sentry-sdk from 1.7.2 to 1.8.0 (#146)
- Bump detect-secrets from 1.2.0 to 1.3.0 (#148)
- Bump mypy from 0.910 to 0.971 (#150)
@leplatrem leplatrem mentioned this pull request Aug 1, 2022
@leplatrem leplatrem added the bug Something isn't working label Aug 1, 2022
leplatrem added a commit that referenced this pull request Aug 1, 2022
**Bug Fixes**

- Retrieve comments from the API if they are private (fixes #154) (#163)

**New Features**

- Show 'Bug XXXX' instead of Bugzilla Ticket in Jira link (#159)
- Add Jira details to log context (#157)
- Retry Jira and Bugzilla on error (fixes #33)  (#152)
- Add counter and timer for action execution (fixes #23, #62, #160, #164)
- Tweak logging (log `500` requests), other logging-adjacent tweaks (#161)

**Configuration**

- Use JB instead of OSS in config.prod.yaml and config.nonprod.yaml (#151, #153)
- Add local config for tests (fixes #121) (#138)

**Documentation**

- Start (naive) troubleshooting section in README (#156)

**Internal Changes**

- Run app as a single uvicorn process (fixes #133) (#162)
- Move initialized action callable to private field (#145)
- Do not sleep in retry tests (#158)

- Bump sentry-sdk from 1.8.0 to 1.9.0 (#167)
- Bump yamllint from 1.26.3 to 1.27.1 (#166)
- Bump atlassian-python-api from 3.20.1 to 3.25.0 (#149)
- Bump dockerflow from 2022.1.0 to 2022.7.0 (#147)
- Bump sentry-sdk from 1.7.2 to 1.8.0 (#146)
- Bump detect-secrets from 1.2.0 to 1.3.0 (#148)
- Bump mypy from 0.910 to 0.971 (#150)
- Bump fastapi from 0.73.0 to 0.79.0 (#168)
@Mossop Mossop deleted the private-comments branch September 8, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants