📎 chore(migration): migrate banner component #5233

manishprivet · 2023-04-05T09:35:24Z

Changes

Migrates Banner Component From https://github.com/nodejs/nodejs.dev/tree/main/src/components/CommonComponents/Banner

Addresses #5193

…nent

AugustinMauroy

LGTM

site.json

components/CommonComponents/Banner/index.tsx

components/CommonComponents/Banner/Banner.stories.tsx

.storybook/main.js

…nent

components/Common/Banner/index.tsx

ovflowd

Per my comment, please either remove bannerBtnText or address its i18n issues.

…nent

ovflowd

I left two nitpicks, but there's one major thing to address yet, can you remove the new translation key from all files except en.json? The key should be added to the translated languages through Crowdin, not through here :)

components/Common/Banner/Banner.stories.tsx

i18n/locales/ca.json

i18n/locales/en.json

manishprivet · 2023-04-08T22:54:18Z

I left two nitpicks, but there's one major thing to address yet, can you remove the new translation key from all files except en.json? The key should be added to the translated languages through Crowdin, not through here :)

@ovflowd Regarding this, I myself didn't want to copy it in each file, but then I saw these two lines present in each file in English language, so I thought maybe a key was needed for Crowdin

  "components.header.buttons.toggleLanguage": "Toggle Language",
  "components.header.buttons.toggleDarkMode": "Toggle dark/light mode",

ovflowd · 2023-04-09T16:54:34Z

@ovflowd Regarding this, I myself didn't want to copy it in each file, but then I saw these two lines present in each file in English language, so I thought maybe a key was needed for Crowdin

That's fine. Just means that the key was not translated yet.

i18n/locales/ca.json

ovflowd

LGTM! Thank you for the considerable effort here. I left one last comment that must be addressed before we merge this PR, but otherwise, fine!

components/Common/Banner/index.tsx

shanpriyan

LGTM! 🚀

Co-authored-by: Shanmughapriyan S <[email protected]> Signed-off-by: Manish Kumar ⛄ <[email protected]>

components/Common/Banner/index.tsx

Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: Manish Kumar ⛄ <[email protected]>

Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>

* feat(unit-test): introduce unit test on website redesign branch (#5178 feat(unit-test): introduce unit test * chore(minor): just a tiny design nitpick * chore: set up storybook (#5191) (#5214) * chore: set up testing-library jest extend (#5231) Co-authored-by: Manish Kumar ⛄ <[email protected]> * chore(dependencies): updated dependencies * feat: create section title component (#5237) Co-authored-by: Wai.Tung <[email protected]> * 📎 chore(migration): migrate banner component (#5233) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * feat: migrate AnimatedPlaceholder component (#5238 Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story. * feat: create article alert component (#5243) * feat: migrate blockquote component (#5259) * feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281) * feat: create article data tag component (#5280) * feat: migrate AuthorList component and add story 🎉 (#5277) Co-authored-by: Michael Esteban <[email protected]> * chore(migration): migrate language selector component (#5266) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> * feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * chore: updated contributing guidelines, eslint rules and storybook templates (#5294) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> * chore: contributing quick fix of example Signed-off-by: Claudio Wunder <[email protected]> * chore: story guide and react spreading Signed-off-by: Claudio Wunder <[email protected]> * chore: remove base styles from old styling * chore: fix storybook styles, imports, typescript config and dependencies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx * chore: adopt turborepo (#5316 * chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries * fix(package.json) Lint command is missing slashes (#5321 fix(package.json) lint:fix missing slashes * moved `DataTag` to `components/Api` (#5317) Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Shanmughapriyan S <[email protected]> * hot-fix: dependency updates and fix dev runtime * chore: updated start command * migration(Layout): newFooter (#5320) Co-authored-by: Claudio Wunder <[email protected]> * feat: migrate EditLink component (#5271) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * feat(blog) Migrate BlogCard component (#5323) Co-authored-by: Michael Esteban <[email protected]> * Issue#5307 - Add framer-motion to the dependency list (#5318) * chore: add remote turbo cache and simplified gh actions cache (#5326)Co-authored-by: Aymen Naghmouchi <[email protected]> * chore: add remote turbo cache and simplified gh actions cache * chore: updated cache rules * chore: more cache rules --------- Co-authored-by: Aymen Naghmouchi <[email protected]> * chore: fix storybook local development mode (#5335) * chore: migrate pagination component (#5331) Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * Chore(node feat) (#5338) Co-authored-by: Claudio Wunder <[email protected]> * chore: migrate releases types (#5324) * hotfix: first element no margin-top * (website redesign) Feat(shellbox): migration (#5234) Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * fix(i18n): translation key (#5347) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * chore: updated dependencies * chore: vercel enable middleware and i18n redirection (#5300) * feat(unit-test): introduce unit test on website redesign branch (#5178 feat(unit-test): introduce unit test * chore: set up storybook (#5191) (#5214) * feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281) * feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236) Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * chore: updated contributing guidelines, eslint rules and storybook templates (#5294) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> * chore: fix storybook styles, imports, typescript config and dependencies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx * chore: adopt turborepo (#5316 * chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries * feat(stability): migrate component * chore(snapshot): update * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fea(stability): update stories + fix * Update components/Api/Stability/index.stories.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fix(i18n): update turkish language direction (#5182) * chore: rollback CODEOWNER changes (#5183) * Sync: merge `major/website-redesign` into `main` (#5356) Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Aymen Naghmouchi <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: Guilherme Araújo <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: HinataKah0 <[email protected]> Co-authored-by: Olaleye Blessing <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: Harkunwar Kochar <[email protected]> Co-authored-by: vasanthkumar <[email protected]> Co-authored-by: Floran Hachez <[email protected]> Co-authored-by: Jatin <[email protected]> * feat(stability): update snapshot * Update components/Api/Stability/index.tsx Co-authored-by: Jithil P Ponnan <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * code format * Update components/Api/Stability/index.tsx Co-authored-by: Jithil P Ponnan <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> --------- Signed-off-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Guilherme Araújo <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: HinataKah0 <[email protected]> Co-authored-by: Olaleye Blessing <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Harkunwar Kochar <[email protected]> Co-authored-by: vasanthkumar <[email protected]> Co-authored-by: Jatin <[email protected]> Co-authored-by: Aymen Naghmouchi <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Yagiz Nizipli <[email protected]> Co-authored-by: Nick Schonning <[email protected]> Co-authored-by: Floran Hachez <[email protected]> Co-authored-by: Jithil P Ponnan <[email protected]>

📎 chore(migration): migrate banner component

6dab118

manishprivet requested a review from a team as a code owner April 5, 2023 09:35

Merge branch 'major/website-redesign' into chore/migrate-banner-compo…

d0a2244

…nent

manishprivet added the website redesign Issue/PR part of the Node.js Website Redesign label Apr 5, 2023

AugustinMauroy approved these changes Apr 5, 2023

View reviewed changes

nschonni reviewed Apr 5, 2023

View reviewed changes

site.json Outdated Show resolved Hide resolved

manishprivet mentioned this pull request Apr 5, 2023

(website redesign) Feat(shellbox): migration #5234

Merged

nschonni reviewed Apr 5, 2023

View reviewed changes

components/CommonComponents/Banner/index.tsx Outdated Show resolved Hide resolved

HinataKah0 reviewed Apr 6, 2023

View reviewed changes

components/CommonComponents/Banner/Banner.stories.tsx Show resolved Hide resolved

ovflowd reviewed Apr 6, 2023

View reviewed changes

.storybook/main.js Outdated Show resolved Hide resolved

manishprivet added 4 commits April 6, 2023 16:02

🪚 refactor(folder-structure): move files to Common from CommonComponents

798dc0f

Merge branch 'major/website-redesign' into chore/migrate-banner-compo…

716006e

…nent

🪚 refactor(html): remove button inside a tag

0b28ef0

merge commit

1fd12b7

nschonni reviewed Apr 6, 2023

View reviewed changes

components/Common/Banner/index.tsx Show resolved Hide resolved

ovflowd requested changes Apr 7, 2023

View reviewed changes

manishprivet added 4 commits April 7, 2023 17:12

🪚 refactor(config): move bannerBtnText to i18n

e7bf751

Merge branch 'major/website-redesign' into chore/migrate-banner-compo…

09dc1ba

…nent

📎 chore(storybook): remove sass addon

1a840e3

🧪 test(storybook): remove bannerBtnText

fcf63cf

manishprivet requested review from nschonni and ovflowd April 7, 2023 11:48

Merge branch 'major/website-redesign' into chore/migrate-banner-compo…

dae35f9

…nent

ovflowd reviewed Apr 8, 2023

View reviewed changes

components/Common/Banner/Banner.stories.tsx Outdated Show resolved Hide resolved

components/Common/Banner/Banner.stories.tsx Show resolved Hide resolved

i18n/locales/ca.json Show resolved Hide resolved

i18n/locales/en.json Outdated Show resolved Hide resolved

🪚 refactor(code): format and conventions

2b2699e

manishprivet requested a review from ovflowd April 8, 2023 23:06

ovflowd reviewed Apr 9, 2023

View reviewed changes

i18n/locales/ca.json Show resolved Hide resolved

ovflowd approved these changes Apr 9, 2023

View reviewed changes

🛠 fix(i18n): remove translation key

716dd46

rodion-arr approved these changes Apr 10, 2023

View reviewed changes

manishprivet removed the request for review from nschonni April 10, 2023 12:16

shanpriyan reviewed Apr 10, 2023

View reviewed changes

components/Common/Banner/index.tsx Outdated Show resolved Hide resolved

shanpriyan approved these changes Apr 10, 2023

View reviewed changes

Update components/Common/Banner/index.tsx

5be3624

Co-authored-by: Shanmughapriyan S <[email protected]> Signed-off-by: Manish Kumar ⛄ <[email protected]>

mikeesto reviewed Apr 10, 2023

View reviewed changes

components/Common/Banner/index.tsx Outdated Show resolved Hide resolved

Update components/Common/Banner/index.tsx

55bc2c4

Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: Manish Kumar ⛄ <[email protected]>

ovflowd merged commit 22b2d1b into nodejs:major/website-redesign Apr 11, 2023

manishprivet deleted the chore/migrate-banner-component branch April 11, 2023 12:41

ovflowd added a commit that referenced this pull request Apr 15, 2023

📎 chore(migration): migrate banner component (#5233)

6ce6923

Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>

ovflowd added a commit that referenced this pull request May 3, 2023

📎 chore(migration): migrate banner component (#5233)

a994f19

Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>

avivkeller removed this from Node.js Website May 3, 2025

Uh oh!

📎 chore(migration): migrate banner component #5233

📎 chore(migration): migrate banner component #5233

Uh oh!

Conversation

manishprivet commented Apr 5, 2023

Changes

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manishprivet commented Apr 8, 2023

Uh oh!

ovflowd commented Apr 9, 2023

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shanpriyan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants